Skip to content

Revert "use spawn_blocking for parsing"#5643

Merged
abernix merged 1 commit intodevfrom
revert-5582-spawn-blocking-parser
Jul 10, 2024
Merged

Revert "use spawn_blocking for parsing"#5643
abernix merged 1 commit intodevfrom
revert-5582-spawn-blocking-parser

Conversation

@abernix
Copy link
Member

@abernix abernix commented Jul 10, 2024

Reverts #5582 which was originally @xuorig's in #5235 which @Geal took over and @garypen ultimately landed.

Unfortunately, it seems this is causing tests to flake at a somewhat pronounced rate — always on Linux. We believe it's just actually the tests, or the way we tested, but we'll revert this for now so dev isn't flaking for everyone trying to develop against it.

I'll open a revert for this revert as a draft after this lands. 😄

@abernix abernix requested a review from a team July 10, 2024 18:52
@abernix abernix requested a review from a team as a code owner July 10, 2024 18:52
@router-perf
Copy link

router-perf bot commented Jul 10, 2024

CI performance tests

  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

@abernix abernix merged commit 31f90b2 into dev Jul 10, 2024
@abernix abernix deleted the revert-5582-spawn-blocking-parser branch July 10, 2024 19:00
abernix added a commit that referenced this pull request Jul 10, 2024
garypen pushed a commit that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant