Merged
Conversation
This reverts commit 47a7386.
|
CI performance tests
|
garypen
pushed a commit
that referenced
this pull request
Jul 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #5582 which was originally @xuorig's in #5235 which @Geal took over and @garypen ultimately landed.
Unfortunately, it seems this is causing tests to flake at a somewhat pronounced rate — always on Linux. We believe it's just actually the tests, or the way we tested, but we'll revert this for now so
devisn't flaking for everyone trying to develop against it.I'll open a revert for this revert as a draft after this lands. 😄