Skip to content

invalidation by entity key#5640

Merged
garypen merged 15 commits intodevfrom
geal/invalidation-entity-key
Jul 24, 2024
Merged

invalidation by entity key#5640
garypen merged 15 commits intodevfrom
geal/invalidation-entity-key

Conversation

@Geal
Copy link
Contributor

@Geal Geal commented Jul 10, 2024


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@github-actions
Copy link
Contributor

@Geal, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@router-perf
Copy link

router-perf bot commented Jul 10, 2024

CI performance tests

  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

@garypen garypen self-assigned this Jul 19, 2024
Gary Pennington added 2 commits July 19, 2024 13:55
In expectation that it will probably fail and we don't want it to.

It wil be re-enabled later.
@garypen garypen marked this pull request as ready for review July 19, 2024 13:05
@garypen garypen requested a review from a team July 19, 2024 13:05
@garypen garypen requested a review from a team as a code owner July 19, 2024 13:05
@garypen garypen enabled auto-merge (squash) July 22, 2024 15:00
@garypen garypen requested a review from bnjjj July 23, 2024 12:45
Copy link
Contributor

@bnjjj bnjjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it intended to have added a skipped test ?

theJC and others added 4 commits July 23, 2024 13:57
#5653)

Co-authored-by: Jesse Rosenberger <git@jro.cc>
Co-authored-by: Gary Pennington <gary@apollographql.com>
Co-authored-by: bryn <bryn@apollographql.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@garypen garypen requested a review from duckki as a code owner July 23, 2024 12:58
@garypen garypen disabled auto-merge July 23, 2024 13:20
@garypen
Copy link
Contributor

garypen commented Jul 23, 2024

Was it intended to have added a skipped test ?

Yes. We should fix up all these invalidation tests once we have merged the invalidation endpoint support. (#5614 )

@garypen garypen requested a review from bnjjj July 23, 2024 13:51
@garypen garypen enabled auto-merge (squash) July 24, 2024 09:09
@garypen garypen merged commit 3bb3f5e into dev Jul 24, 2024
@garypen garypen deleted the geal/invalidation-entity-key branch July 24, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants