Skip to content

Create the invalidation endpoint for entity caching#5614

Merged
bnjjj merged 36 commits intodevfrom
bnjjj/feat_cache_invalidation_endpoint
Jul 30, 2024
Merged

Create the invalidation endpoint for entity caching#5614
bnjjj merged 36 commits intodevfrom
bnjjj/feat_cache_invalidation_endpoint

Conversation

@bnjjj
Copy link
Contributor

@bnjjj bnjjj commented Jul 5, 2024

Create the invalidation endpoint for entity caching

TODO:

  • the response to invalidation requests on the endpoint returns the number of invalidated entries. Could we return errors too there? Users would be able to react to errors during invalidation (ex: to retry them)
  • the extensions contained a Vec<InvalidationRequest> but the endpoint only accept a single InvalidationRequest. Do we want to align them?
  • the endpoint directly calls the handle_request function instead of sending the request to the invalidation task. We may want to have all requests go through that task. That implies passing a channel sender along with the requests, to get notified once the invalidation is finished). It might also requires transmitting the current span too, so the invalidation execution happens under the same trace
  • handle the shared_key parameter

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

bnjjj added 6 commits June 28, 2024 23:19
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2024

@bnjjj, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@router-perf
Copy link

router-perf bot commented Jul 5, 2024

CI performance tests

  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

@bnjjj bnjjj force-pushed the bnjjj/feat_cache_invalidation_endpoint branch from ffc5a4d to cbb1581 Compare July 15, 2024 15:33
bnjjj added 4 commits July 15, 2024 17:39
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj marked this pull request as ready for review July 17, 2024 06:40
@bnjjj bnjjj requested a review from a team July 17, 2024 06:40
@bnjjj bnjjj requested review from a team as code owners July 17, 2024 06:40
bnjjj added 2 commits July 17, 2024 10:56
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@abernix abernix requested review from IvanGoncharov and garypen July 17, 2024 12:46
bnjjj added 2 commits July 22, 2024 16:13
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj requested review from BrynCooke and garypen July 23, 2024 08:24
bnjjj added 5 commits July 23, 2024 10:44
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@garypen garypen mentioned this pull request Jul 23, 2024
6 tasks
bnjjj added 3 commits July 23, 2024 15:54
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
bnjjj added 7 commits July 25, 2024 10:43
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj requested review from IvanGoncharov and garypen July 25, 2024 12:33
@bnjjj bnjjj merged commit d940c3f into dev Jul 30, 2024
@bnjjj bnjjj deleted the bnjjj/feat_cache_invalidation_endpoint branch July 30, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants