Skip to content

it_rate_limit_subgraph_requests test changed to multi-threaded runtime #2218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrynCooke merged 1 commit into from
Dec 6, 2022
Merged

it_rate_limit_subgraph_requests test changed to multi-threaded runtime #2218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions NEXT_CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,12 @@ By [@USERNAME](https://github.com/USERNAME) in https://github.com/apollographql/
-->

# [x.x.x] (unreleased) - 2022-mm-dd


## 🛠 Maintenance

### it_rate_limit_subgraph_requests fixed ([Issue #2213](https://github.com/apollographql/router/issues/2213))

This test was failing frequently due to it being a timing test being run in a single threaded tokio runtime.

By [@bryncooke](https://github.com/bryncooke) in https://github.com/apollographql/router/pull/2218
2 changes: 1 addition & 1 deletion apollo-router/src/plugins/traffic_shaping/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,7 +579,7 @@ mod test {
);
}

#[tokio::test]
#[tokio::test(flavor = "multi_thread")]
async fn it_rate_limit_subgraph_requests() {
let config = serde_yaml::from_str::<serde_json::Value>(
r#"
Expand Down