it_rate_limit_subgraph_requests test changed to multi-threaded runtime#2218
Merged
it_rate_limit_subgraph_requests test changed to multi-threaded runtime#2218
Conversation
Fixes #2213 Ran in a tight loop 1000 times would fail pretty much immediately on the single threaded runtime. Completed 1000 runs successfully when changed to multithreaded.
BrynCooke
force-pushed
the
bryn/fix-flaky-traffic-shaping-test
branch
from
87472f2 to
e35a2e3
Compare
bnjjj
approved these changes
Dec 6, 2022
garypen
approved these changes
Dec 6, 2022
Contributor
garypen
left a comment
garypen
left a comment
There was a problem hiding this comment.
I've been running it like this since last week on a variety of branches and it never failed, so fingers crossed....
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2213
Ran in a tight loop 1000 times would fail pretty much immediately on the single threaded runtime. Completed 1000 runs successfully when changed to multithreaded.