Merged
Conversation
fixes: #2135 This PR repurposes the -debug image to make it the basis for a memory tracking image which we can use for investigating router memory issues via heaptrack. (https://github.com/KDE/heaptrack) The PR is a *breaking* change because it now automatically starts the router under the control of heaptrack. Technically, it's not really a breaking change and it's certainly not an API change, but I really want to draw people's attention to the fact that the debug image will now execute a lot slower than the non-debug image and use a lot more memory (to track memory with...). I've updated the docker documentation to show how to mount a local directory to store the heaptrack data. I haven't updated the kubernetes docs, because we don't go into that level of detail and we assume that a kubernetes devops person would know how to allocate and mount a PVC.
garypen
requested review from
BrynCooke,
Geal and
o0Ignition0o
and removed request for
a team
Geal
approved these changes
Nov 23, 2022
| RUN rm -rf /var/lib/apt/lists/* | ||
|
|
||
| # Run the Router downloader which puts Router into current working directory | ||
| RUN curl -sSL https://router.apollo.dev/download/nix/${ROUTER_RELEASE}/ | sh |
Contributor
There was a problem hiding this comment.
the router binary that is used here will be without debug symbols, right? Will heaptrack be able to display enough information?
Contributor
Author
There was a problem hiding this comment.
You get the output we were looking at this morning. Things are mangled but you can roughly work out what is happening. I do think we can improve this further down the line, this is a step along the way.
This was referenced Nov 24, 2022
bnjjj
reviewed
Nov 24, 2022
BrynCooke
approved these changes
Nov 24, 2022
Contributor
BrynCooke
left a comment
BrynCooke
left a comment
There was a problem hiding this comment.
Had a go looks great:
heaptrack stats:
allocations: 2036
leaked allocations: 202
temporary allocations: 203
Heaptrack finished! Now run the following to investigate the data:
heaptrack --analyze "/dist/data/router_heaptrack.gz"
garypen
pushed a commit
that referenced
this pull request
Nov 30, 2022
fixes: #2135 fixes: #2145 This PR repurposes the -debug image to make it the basis for a memory tracking image which we can use for investigating router memory issues via heaptrack. (https://github.com/KDE/heaptrack) The PR is a *breaking* change because it now automatically starts the router under the control of heaptrack. Technically, it's not really a breaking change and it's certainly not an API change, but I really want to draw people's attention to the fact that the debug image will now execute a lot slower than the non-debug image and use a lot more memory (to track memory with...). I've updated the docker documentation to show how to mount a local directory to store the heaptrack data. I haven't updated the kubernetes docs, because we don't go into that level of detail and we assume that a kubernetes devops person would know how to allocate and mount a PVC.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #2135
fixes: #2145
This PR repurposes the -debug image to make it the basis for a memory tracking image which we can use for investigating router memory issues via heaptrack. (https://github.com/KDE/heaptrack)
The PR is a breaking change because it now automatically starts the router under the control of heaptrack. Technically, it's not really a breaking change and it's certainly not an API change, but I really want to draw people's attention to the fact that the debug image will now execute a lot slower than the non-debug image and use a lot more memory (to track memory with...).
I've updated the docker documentation to show how to mount a local directory to store the heaptrack data. I haven't updated the kubernetes docs, because we don't go into that level of detail and we assume that a kubernetes devops person would know how to allocate and mount a PVC.