update the released package name in Docker image construction#1397
update the released package name in Docker image construction#1397
Conversation
We changed the released package names in #1393 to include the full target triplet
|
@Geal your pull request is missing a changelog! |
garypen
left a comment
There was a problem hiding this comment.
Good timing. I was just going to do that!
garypen
left a comment
There was a problem hiding this comment.
Hmm, now that I've approved it, it does mean that it will only work from the next release forwards. We'll have to watch out for that if anyone files an issue.
|
@Geal @garypen Couldn't both the waiting for the release and the "forward support only" both be avoided if we used the installer script rather than the direct link to the tarball? The installer script works off GitHub Releases so the I'd also argue that we should be doing that anyways to make sure all the downloads are going through an endpoint that we control. If that makes sense, I'm happy to make a PR. |
|
I think the existing code pre-dates the creation of the installer script, so bringing it into line with the installer seems sensible. I presume the PR would be to replace the explicit |
|
closing in favor of #1629 |
We changed the released package names in #1393 to include the full
target triplet