insert the full target triplet in the package name#1393
Merged
Conversation
code extracted from rover's xtask command
This comment has been minimized.
This comment has been minimized.
Member
|
The Docker image itself isn't published until release-time, right? Is the concern about the time where it lives on |
garypen
approved these changes
Jul 13, 2022
Contributor
garypen
left a comment
garypen
left a comment
There was a problem hiding this comment.
The docker file change is fine. We only do that on release. One naming suggestion which is a NIT and can be ignored if you like.
added 2 commits
July 13, 2022 14:58
Geal
pushed a commit
that referenced
this pull request
Jul 13, 2022
We changed the released package names in #1393 to include the full target triplet
Contributor
Author
|
I'm opening #1397 as a follow up, because the diy image construction scripts are likely used from a cloned repository |
EverlastingBugstopper
approved these changes
Jul 13, 2022
Contributor
EverlastingBugstopper
left a comment
EverlastingBugstopper
left a comment
There was a problem hiding this comment.
thank you!!
abernix
added a commit
that referenced
this pull request
Jul 15, 2022
This follows-up #1393 with the nececessary changes to the install script which allows the installer to locate (and extract) the right binaries during the `router.apollo.dev` installation bits.
Merged
o0Ignition0o
added a commit
that referenced
this pull request
Jul 18, 2022
This reverts commit b38d594.
abernix
pushed a commit
that referenced
this pull request
Jul 25, 2022
code extracted from rover's xtask command
abernix
pushed a commit
that referenced
this pull request
Aug 25, 2022
code extracted from rover's xtask command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1385
code extracted from rover's xtask command
I updated the URL in the Dockerfile, but that means it would not work until the next release, should that go into a separate PR instead?