Revert "fix: make composeDirective argument non-nullable"#3281
Merged
dariuszkuc merged 1 commit intomainfrom Jun 25, 2025
Merged
Revert "fix: make composeDirective argument non-nullable"#3281dariuszkuc merged 1 commit intomainfrom
dariuszkuc merged 1 commit intomainfrom
Conversation
This reverts commit 7799ad1.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
sachindshinde
approved these changes
Jun 25, 2025
dariuszkuc
added a commit
that referenced
this pull request
Jun 25, 2025
Since we cannot easily fix incorrect directive definition (#3281) without breaking our clients. This PR improves error messages when `@composeDirective` arguments are NULL or empty strings. Previous message on undefined/null argument value `Cannot read properties of undefined (reading '0')` New message `Argument to @composeDirective in subgraph "${sg.name}" cannot be NULL or an empty String`
dariuszkuc
added a commit
that referenced
this pull request
Jun 25, 2025
Since we cannot easily fix incorrect directive definition (#3281) without breaking our clients. This PR improves error messages when `@composeDirective` arguments are NULL or empty strings. Previous message on undefined/null argument value `Cannot read properties of undefined (reading '0')` New message `Argument to @composeDirective in subgraph "${sg.name}" cannot be NULL or an empty String`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #3278