fix(composition): Handle output type covariance properly in satisfiability#3277
Merged
sachindshinde merged 2 commits intomainfrom Jun 24, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: fdecbd1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
dariuszkuc
approved these changes
Jun 24, 2025
dariuszkuc
force-pushed
the
sachin/fix-output-type-covariance-in-satisfiability
branch
from
5171b0f to
790844d
Compare
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 7 changed, 0 removedBuild ID: 4f17a68972dd49935c987bcc URL: https://www.apollographql.com/docs/deploy-preview/4f17a68972dd49935c987bcc |
sachindshinde
deleted the
sachin/fix-output-type-covariance-in-satisfiability
branch
dariuszkuc
pushed a commit
that referenced
this pull request
Jun 24, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @apollo/composition@2.11.1 ### Patch Changes - Adding new CompositionOption `maxValidationSubgraphPaths`. This value represents the maximum number of SubgraphPathInfo objects that may exist in a ValidationTraversal when checking for satisfiability. Setting this value can help composition error before running out of memory. Default is 1,000,000. ([#3254](#3254)) - Fix bug in composition where, when a field's type in a subgraph is a subtype of the field's type in the supergraph, the satisfiability validation spuriously succeeds/errors. ([#3277](#3277)) - Updated dependencies \[[`7799ad1717becf15fb0e82f89619f2ec8a24b4d4`](7799ad1), [`b26794c5724ef23d1f0fd45a40aee3d301557489`](b26794c), [`51bed5be49d8e87adae59f568315c9e3488a91e0`](51bed5b)]: - @apollo/federation-internals@2.11.1 - @apollo/query-graphs@2.11.1 ## @apollo/gateway@2.11.1 ### Patch Changes - Updated dependencies \[[`7799ad1717becf15fb0e82f89619f2ec8a24b4d4`](7799ad1), [`b26794c5724ef23d1f0fd45a40aee3d301557489`](b26794c), [`51bed5be49d8e87adae59f568315c9e3488a91e0`](51bed5b)]: - @apollo/federation-internals@2.11.1 - @apollo/composition@2.11.1 - @apollo/query-planner@2.11.1 ## @apollo/federation-internals@2.11.1 ### Patch Changes - fix: make composeDirective argument non-nullable. ([#3278](#3278)) Per our [docs](https://www.apollographql.com/docs/graphos/schema-design/federated-schemas/reference/directives#composedirective), `@composeDirective` requires non-nullable value to be passed as an argument. Our [validations](https://github.com/apollographql/federation/blob/main/composition-js/src/composeDirectiveManager.ts#L250-L255) were checking for valid values (it has to be a string that starts with `@`), but the generated schema was incorrectly specifying that the argument was nullable. - Adding new CompositionOption `maxValidationSubgraphPaths`. This value represents the maximum number of SubgraphPathInfo objects that may exist in a ValidationTraversal when checking for satisfiability. Setting this value can help composition error before running out of memory. Default is 1,000,000. ([#3254](#3254)) ## @apollo/query-graphs@2.11.1 ### Patch Changes - Fix bug in composition where, when a field's type in a subgraph is a subtype of the field's type in the supergraph, the satisfiability validation spuriously succeeds/errors. ([#3277](#3277)) - Updated dependencies \[[`7799ad1717becf15fb0e82f89619f2ec8a24b4d4`](7799ad1), [`b26794c5724ef23d1f0fd45a40aee3d301557489`](b26794c)]: - @apollo/federation-internals@2.11.1 ## @apollo/query-planner@2.11.1 ### Patch Changes - Updated dependencies \[[`7799ad1717becf15fb0e82f89619f2ec8a24b4d4`](7799ad1), [`b26794c5724ef23d1f0fd45a40aee3d301557489`](b26794c), [`51bed5be49d8e87adae59f568315c9e3488a91e0`](51bed5b)]: - @apollo/federation-internals@2.11.1 - @apollo/query-graphs@2.11.1 ## @apollo/subgraph@2.11.1 ### Patch Changes - Updated dependencies \[[`7799ad1717becf15fb0e82f89619f2ec8a24b4d4`](7799ad1), [`b26794c5724ef23d1f0fd45a40aee3d301557489`](b26794c)]: - @apollo/federation-internals@2.11.1 ## apollo-federation-integration-testsuite@2.11.1 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
sachindshinde
added a commit
to apollographql/router
that referenced
this pull request
Jun 26, 2025
…eTransition()` (#7740) This PR ports `ValidationState()` from the JS codebase, except `validateTransition()`. Note that: 1. We've skipped `currentSubgraphs()`, as Rust composition doesn't currently at least give node information. 2. The subgraph context keys were strings in JS, but that was just because they needed to be used in JS `Map`s efficiently. We don't have that restriction in Rust, so we use actual data structures for the keys. - As part of this, we don't need actually need a map from subgraph names to subgraph enum values (that was used in JS to avoid issues with separator characters in the keys potentially being in the subgraph names). 3. We did not port any fixes from apollographql/federation#3277 yet to this code.
10 tasks
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two bugs in the satisfiability code when the subgraph type differs from the supergraph type due to output type covariance: