docs: review subgraph should contribute to rating#3252
Conversation
|
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 1 changed, 0 removedBuild ID: 6d4d3546330e913dff9975f5 URL: https://www.apollographql.com/docs/deploy-preview/6d4d3546330e913dff9975f5 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Meschreiber
left a comment
There was a problem hiding this comment.
Ah, good catch! Thanks as always @DaleSeo 🙇♀️
It seems a bit counterintuitive that the `Reviews` subgraph contributes to the `inStock` field of the `Product` type. I'd like to update the code example so that it contributes to the `rating` field instead. This change is also consistent with the code example in the overview section of [the document](http://apollographql.com/docs/graphos/schema-design/federated-schemas/entities/intro).
It seems a bit counterintuitive that the
Reviewssubgraph contributes to theinStockfield of theProducttype. I'd like to update the code example so that it contributes to theratingfield instead. This change is also consistent with the code example in the overview section of the document.