Skip to content

docs: review subgraph should contribute to rating#3252

Merged
Meschreiber merged 1 commit intomainfrom
DaleSeo-patch-1
Apr 22, 2025
Merged

docs: review subgraph should contribute to rating#3252
Meschreiber merged 1 commit intomainfrom
DaleSeo-patch-1

Conversation

@DaleSeo
Copy link
Member

@DaleSeo DaleSeo commented Apr 22, 2025

It seems a bit counterintuitive that the Reviews subgraph contributes to the inStock field of the Product type. I'd like to update the code example so that it contributes to the rating field instead. This change is also consistent with the code example in the overview section of the document.

@DaleSeo DaleSeo self-assigned this Apr 22, 2025
@changeset-bot
Copy link

changeset-bot bot commented Apr 22, 2025

⚠️ No Changeset found

Latest commit: ad4e639

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DaleSeo DaleSeo marked this pull request as ready for review April 22, 2025 15:38
@DaleSeo DaleSeo requested a review from a team as a code owner April 22, 2025 15:38
@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Apr 22, 2025

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 1 changed, 0 removed
* graphos/schema-design/federated-schemas/entities/intro.mdx

Build ID: 6d4d3546330e913dff9975f5

URL: https://www.apollographql.com/docs/deploy-preview/6d4d3546330e913dff9975f5

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@DaleSeo DaleSeo requested a review from Meschreiber April 22, 2025 15:38
Copy link
Contributor

@Meschreiber Meschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch! Thanks as always @DaleSeo 🙇‍♀️

@Meschreiber Meschreiber merged commit adc03a3 into main Apr 22, 2025
17 checks passed
@Meschreiber Meschreiber deleted the DaleSeo-patch-1 branch April 22, 2025 17:02
Hunter-apollo pushed a commit that referenced this pull request May 28, 2025
It seems a bit counterintuitive that the `Reviews` subgraph contributes
to the `inStock` field of the `Product` type. I'd like to update the
code example so that it contributes to the `rating` field instead. This
change is also consistent with the code example in the overview section
of [the
document](http://apollographql.com/docs/graphos/schema-design/federated-schemas/entities/intro).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants