Skip to content

allow @connect as default import#3240

Merged
lennyburdette merged 1 commit intonextfrom
lb/connect-without-importing
Apr 8, 2025
Merged

allow @connect as default import#3240
lennyburdette merged 1 commit intonextfrom
lb/connect-without-importing

Conversation

@lennyburdette
Copy link
Contributor

according to https://specs.apollo.dev/link/v1.0/, we actually shouldn't be importing @connect — it's available by default when importing the spec. it can be renamed with as:. calling import: ["@connect"] should actually be importing something called @connect__connect, but we'll leave the current behavior.

this change applies only to join__directive serialization.

according to https://specs.apollo.dev/link/v1.0/, we actually shouldn't be importing `@connect` — it's available by default when importing the spec. it can be renamed with `as:`. calling `import: ["@connect"]` should actually be importing something called `@connect__connect`, but we'll leave the current behavior.

this change applies only to join__directive serialization.
@lennyburdette lennyburdette requested a review from a team April 7, 2025 16:08
@lennyburdette lennyburdette requested a review from a team as a code owner April 7, 2025 16:08
@changeset-bot
Copy link

changeset-bot bot commented Apr 7, 2025

⚠️ No Changeset found

Latest commit: 02bbdee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Apr 7, 2025

⚠️ Docs preview not attached to branch

The preview was not built because the PR's base branch next is not in the list of sources.

An Apollo team member can comment one of the following commands to dictate which branch to attach the preview to:

  • !docs set-base-branch version-0.x
  • !docs set-base-branch main

Build ID: 7d9a618331ad0c5e2158cd22

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 7, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

@dylan-apollo dylan-apollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure I've done this before and it worked 🤔. Did something change at one point? Also, do we also need to update LSP?

@lennyburdette
Copy link
Contributor Author

it's never worked afaik

@lennyburdette
Copy link
Contributor Author

i don't think there's anything to change in the language server? maybe a snippet but i don't see one for the link

@lennyburdette lennyburdette merged commit 1e01dc4 into next Apr 8, 2025
17 checks passed
@lennyburdette lennyburdette deleted the lb/connect-without-importing branch April 8, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants