feat: Add request param to didEncounter method#3194
Merged
clenfest merged 2 commits intoapollographql:mainfrom Dec 19, 2024
kamila-brylewska-zendesk:feat/add-request-param-to-didEncouterError-method
Merged
feat: Add request param to didEncounter method#3194clenfest merged 2 commits intoapollographql:mainfrom kamila-brylewska-zendesk:feat/add-request-param-to-didEncouterError-method
clenfest merged 2 commits intoapollographql:mainfrom
kamila-brylewska-zendesk:feat/add-request-param-to-didEncouterError-method
Conversation
|
@kamila-brylewska-zendesk: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
🦋 Changeset detectedLatest commit: 15f0081 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
✅ Docs Preview ReadyNo new or changed pages found. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
tninesling
approved these changes
Dec 17, 2024
Contributor
Author
|
Hi @tninesling! Thank you for approval! Tests for Node.js 16 timeouted (they didn't for first time) and I can't rerun them as I don't have permission. Can I merge this PR? |
Contributor
Hi @kamila-brylewska-zendesk, that test is flakey. I'm rerunning it and I'll merge it once it passes. |
lennyburdette
added a commit
that referenced
this pull request
Feb 13, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @apollo/composition@2.10.0 ### Minor Changes - Adds the ability to compose and serialize directives for [Apollo Connectors](https://go.apollo.dev/connectors). To use Apollo Connectors, compose your supergraphs using [GraphOS](https://www.apollographql.com/docs/graphos/platform/schema-management) or [rover](https://www.apollographql.com/docs/rover/commands/dev), and run your supergraph in [Apollo Router](https://www.apollographql.com/docs/graphos/routing) 2.0.0 or higher. ([#3215](#3215)) ### Patch Changes - Updated dependencies \[[`8927e315ab0e865ef3ff12320f265ee95588b899`](8927e31), [`8927e315ab0e865ef3ff12320f265ee95588b899`](8927e31)]: - @apollo/query-graphs@2.10.0 - @apollo/federation-internals@2.10.0 ## @apollo/gateway@2.10.0 ### Minor Changes - Adds the ability to compose and serialize directives for [Apollo Connectors](https://go.apollo.dev/connectors). To use Apollo Connectors, compose your supergraphs using [GraphOS](https://www.apollographql.com/docs/graphos/platform/schema-management) or [rover](https://www.apollographql.com/docs/rover/commands/dev), and run your supergraph in [Apollo Router](https://www.apollographql.com/docs/graphos/routing) 2.0.0 or higher. ([#3215](#3215)) - Add request parameter to didEncounterError method ([#3194](#3194)) ### Patch Changes - Updated dependencies \[[`8927e315ab0e865ef3ff12320f265ee95588b899`](8927e31), [`8927e315ab0e865ef3ff12320f265ee95588b899`](8927e31)]: - @apollo/query-planner@2.10.0 - @apollo/composition@2.10.0 - @apollo/federation-internals@2.10.0 ## @apollo/federation-internals@2.10.0 ### Minor Changes - Adds the ability to compose and serialize directives for [Apollo Connectors](https://go.apollo.dev/connectors). To use Apollo Connectors, compose your supergraphs using [GraphOS](https://www.apollographql.com/docs/graphos/platform/schema-management) or [rover](https://www.apollographql.com/docs/rover/commands/dev), and run your supergraph in [Apollo Router](https://www.apollographql.com/docs/graphos/routing) 2.0.0 or higher. ([#3215](#3215)) ### Patch Changes - Incorporate changes from v2.9.3 ([#3215](#3215)) ## @apollo/query-graphs@2.10.0 ### Minor Changes - Adds the ability to compose and serialize directives for [Apollo Connectors](https://go.apollo.dev/connectors). To use Apollo Connectors, compose your supergraphs using [GraphOS](https://www.apollographql.com/docs/graphos/platform/schema-management) or [rover](https://www.apollographql.com/docs/rover/commands/dev), and run your supergraph in [Apollo Router](https://www.apollographql.com/docs/graphos/routing) 2.0.0 or higher. ([#3215](#3215)) ### Patch Changes - Updated dependencies \[[`8927e315ab0e865ef3ff12320f265ee95588b899`](8927e31), [`8927e315ab0e865ef3ff12320f265ee95588b899`](8927e31)]: - @apollo/federation-internals@2.10.0 ## @apollo/query-planner@2.10.0 ### Minor Changes - Adds the ability to compose and serialize directives for [Apollo Connectors](https://go.apollo.dev/connectors). To use Apollo Connectors, compose your supergraphs using [GraphOS](https://www.apollographql.com/docs/graphos/platform/schema-management) or [rover](https://www.apollographql.com/docs/rover/commands/dev), and run your supergraph in [Apollo Router](https://www.apollographql.com/docs/graphos/routing) 2.0.0 or higher. ([#3215](#3215)) ### Patch Changes - Updated dependencies \[[`8927e315ab0e865ef3ff12320f265ee95588b899`](8927e31), [`8927e315ab0e865ef3ff12320f265ee95588b899`](8927e31)]: - @apollo/query-graphs@2.10.0 - @apollo/federation-internals@2.10.0 ## @apollo/subgraph@2.10.0 ### Minor Changes - Adds the ability to compose and serialize directives for [Apollo Connectors](https://go.apollo.dev/connectors). To use Apollo Connectors, compose your supergraphs using [GraphOS](https://www.apollographql.com/docs/graphos/platform/schema-management) or [rover](https://www.apollographql.com/docs/rover/commands/dev), and run your supergraph in [Apollo Router](https://www.apollographql.com/docs/graphos/routing) 2.0.0 or higher. ([#3215](#3215)) ### Patch Changes - When resolving references, skip type resolution if the reference resolves to null. ([#3215](#3215)) - Updated dependencies \[[`8927e315ab0e865ef3ff12320f265ee95588b899`](8927e31), [`8927e315ab0e865ef3ff12320f265ee95588b899`](8927e31)]: - @apollo/federation-internals@2.10.0 ## apollo-federation-integration-testsuite@2.10.0 ### Minor Changes - Adds the ability to compose and serialize directives for [Apollo Connectors](https://go.apollo.dev/connectors). To use Apollo Connectors, compose your supergraphs using [GraphOS](https://www.apollographql.com/docs/graphos/platform/schema-management) or [rover](https://www.apollographql.com/docs/rover/commands/dev), and run your supergraph in [Apollo Router](https://www.apollographql.com/docs/graphos/routing) 2.0.0 or higher. ([#3215](#3215)) --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Lenny Burdette <lenny@apollographql.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello :)
Short description: This PR enhances didEncounterError method in RemoteGraphQLDataSource class.
During implementation of didEncounterError I noticed I didn't have enough information about subgraph request. As far as I know context is the same for all subgraph requests.
I noticed that you don't test didEncounterError and I didn't change that with my request.