Skip to content

Split out satisfiability from composeServices#3049

Merged
dylan-apollo merged 4 commits intonextfrom
dylan/split-satisfiability
Jun 26, 2024
Merged

Split out satisfiability from composeServices#3049
dylan-apollo merged 4 commits intonextfrom
dylan/split-satisfiability

Conversation

@dylan-apollo
Copy link
Member

Create a validateSatisfiability function separate from composeServces. Allow fow disabling satisfiability when running composeServices.

This is part of #3046, split out for easier review.

…ices`. Allow fow disabling satisfiability when running `composeServices`.

Co-authored-by: Taylor Jones <45475656+tayrrible@users.noreply.github.com>
@dylan-apollo dylan-apollo requested a review from a team June 25, 2024 21:36
@dylan-apollo dylan-apollo requested a review from a team as a code owner June 25, 2024 21:36
@changeset-bot
Copy link

changeset-bot bot commented Jun 25, 2024

⚠️ No Changeset found

Latest commit: 04db517

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dylan-apollo dylan-apollo mentioned this pull request Jun 25, 2024
3 tasks
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 25, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@clenfest clenfest self-requested a review June 25, 2024 21:43
@tayrrible tayrrible requested a review from clenfest June 25, 2024 22:30
@dylan-apollo dylan-apollo merged commit 6cf28f2 into next Jun 26, 2024
@dylan-apollo dylan-apollo deleted the dylan/split-satisfiability branch June 26, 2024 16:28
sachindshinde pushed a commit that referenced this pull request Sep 9, 2024
<!-- [CNN-217] -->

TODO:

- [x] Merge #3048 and rebase this 
- [x] Merge #3049 and rebase this
- [x] Merge #3050 and rebase this

Summary:

- Removes support for `@source*` directives
- Adds support for `@connect` and `@source`

[CNN-217]:
https://apollographql.atlassian.net/browse/CNN-217?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

---------

Co-authored-by: Lenny Burdette <lenny@apollographql.com>
Co-authored-by: Ben Newman <ben@apollographql.com>
Co-authored-by: Taylor Jones <45475656+tayrrible@users.noreply.github.com>
Co-authored-by: Taylor Jones <taylor@apollographql.com>
Co-authored-by: Nicholas Cioli <nicholas.cioli@apollographql.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants