Fix nested fragments on interfaces (when a directive is present)#2864
Closed
trevor-scheer wants to merge 1 commit intomainfrom
Closed
Fix nested fragments on interfaces (when a directive is present)#2864trevor-scheer wants to merge 1 commit intomainfrom
trevor-scheer wants to merge 1 commit intomainfrom
Conversation
|
✅ Deploy Preview for apollo-federation-docs canceled.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Member
|
Superseded by #2875 |
dariuszkuc
added a commit
that referenced
this pull request
Dec 5, 2023
… query graphs This PR addresses issues with handling fragments when they specify directive conditions: * when exploding the types we were not propagating directive conditions * when processing fragment that specifies super type of an existing type and also specifies directive condition, we were incorrectly preserving the unnecessary type condition. This type condition was problematic as it could be referecing types from supergraph that were not available in the local schema. Instead, we now drop the redundant type condition and only preserve the directives (if specified). Related: * fixes #2862 * supersedes #2864
dariuszkuc
added a commit
that referenced
this pull request
Dec 5, 2023
…phs (#2875) This PR addresses issues with handling fragments when they specify directive conditions: * when exploding the types we were not propagating directive conditions * when processing fragment that specifies super type of an existing type and also specifies directive condition, we were incorrectly preserving the unnecessary type condition. This type condition was problematic as it could be referencing types from supergraph that were not available in the local schema. Instead, we now drop the redundant type condition and only preserve the directives (if specified). Related: * fixes #2862 * supersedes #2864 --------- Co-authored-by: Chris Lenfest <clenfest@apollographql.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following query:
Blows up with the following error:
When the
@testdirective is removed, we collapse the inline fragments and this error doesn't occur, but we can't do that when a directive application is present.This seems to be due to the way that the query planner handles interface conditions, by expanding them into their runtime types. My understanding right now is roughly this:
Expanding the above query in theory looks something like:
...but this T2 as parent type of an I2 is triggering the error since
canRebaseOnis returning false.Minimal reproduction of #2862