-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure MaybeMasked
doesn't unwrap if it contains any
#12204
Conversation
🦋 Changeset detectedLatest commit: 2f5963b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Docs Preview ReadyNo new or changed pages found. |
commit: |
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also wait for the user feedback on Discord if there is something else that gets past ContainsFragmentsRefs
.
@@ -20,7 +20,6 @@ export type UnwrapFragmentRefs<TData> = | |||
> | |||
> | |||
> | |||
: TData extends Array<infer TItem> ? Array<UnwrapFragmentRefs<TItem>> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Prevents
MaybeMasked
from unwrapping the type asUnmasked
if the type containsany
.Example:
This also ensures that types that contain tuples are not reduced down to an array of their subtypes.
This should fix the issue described in https://discord.com/channels/1022972389463687228/1315733932934959126/1315733932934959126