Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip unmasking for types without fragments #12152

Merged
merged 6 commits into from
Nov 20, 2024

Conversation

phryneas
Copy link
Member

I'm still looking into ways to make this potentially faster, but this should already enable a "safer" option for types that didn't contain fragments in the first place.

@svc-apollo-docs
Copy link

svc-apollo-docs commented Nov 20, 2024

✅ Docs Preview Ready

No new or changed pages found.

Copy link

changeset-bot bot commented Nov 20, 2024

🦋 Changeset detected

Latest commit: 906919d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Nov 20, 2024

npm i https://pkg.pr.new/@apollo/client@12152

commit: dc98710

Copy link
Contributor

github-actions bot commented Nov 20, 2024

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 40.64 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 50.8 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 47.68 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 36.15 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 33.56 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.26 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.24 KB (0%)
import { useQuery } from "dist/react/index.js" 5.21 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.3 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.71 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.78 KB (0%)
import { useMutation } from "dist/react/index.js" 3.62 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.85 KB (0%)
import { useSubscription } from "dist/react/index.js" 4.43 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 3.48 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.51 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.17 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 5.01 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.66 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 5.09 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.74 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3.42 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 3.36 KB (0%)
import { useFragment } from "dist/react/index.js" 2.37 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.31 KB (0%)

T extends { " $fragmentRefs"?: any } ?
UnwrapFragmentRefs<T>
: { [K in keyof T]: FastForwardUnmask<T[K]> }
: T;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might need to handle arrays in here, otherwise if the type is buried in an array, I think it might miss it. Does this work with this type?

type Query = {
  posts: Array<{
    __typename: "Post",
    id: string;
  } & { " $fragmentRefs"?: {...}>
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Object mapping works recursively over arrays, too, if it's a "simple object mapping", meaning without renaming keys etc.

So in most cases we should not need any extra handling.

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 906919d
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/673e323d8874c8000898de58
😎 Deploy Preview https://deploy-preview-12152--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jerelmiller jerelmiller merged commit 78137ec into release-3.12 Nov 20, 2024
36 checks passed
@jerelmiller jerelmiller deleted the pr/skip-unrelated-unmasking branch November 20, 2024 19:15
@github-actions github-actions bot mentioned this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants