-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data masking] Allow null
as a valid from
value
#12131
Conversation
🦋 Changeset detectedLatest commit: f30d83c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Docs Preview ReadyNo new or changed pages found. |
commit: |
Here is the updated component with this change: apollographql/spotify-showcase@c630fa9 Much cleaner and required much less updating. |
94e0f01
to
f30d83c
Compare
size-limit report 📦
|
While trying out data masking with the Spotify showcase, I discovered some cases where it was a bit difficult to adopt data masking without some significant refactors. For example, see apollographql/spotify-showcase@a24c3ed. In this component, I had to split out a fallback component and a component that renders the non-null case simply because we can't conditionally render hooks and
null
is not a validfrom
value inuseFragment
. By adding support fornull
, it should make data masking a bit easier to adopt by avoiding these types of refactors where a fallback state is perfectly valid.