Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data masking] Allow null as a valid from value #12131

Merged
merged 4 commits into from
Nov 15, 2024

Conversation

jerelmiller
Copy link
Member

While trying out data masking with the Spotify showcase, I discovered some cases where it was a bit difficult to adopt data masking without some significant refactors. For example, see apollographql/spotify-showcase@a24c3ed. In this component, I had to split out a fallback component and a component that renders the non-null case simply because we can't conditionally render hooks and null is not a valid from value in useFragment. By adding support for null, it should make data masking a bit easier to adopt by avoiding these types of refactors where a fallback state is perfectly valid.

Copy link

changeset-bot bot commented Nov 14, 2024

🦋 Changeset detected

Latest commit: f30d83c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svc-apollo-docs
Copy link

svc-apollo-docs commented Nov 14, 2024

✅ Docs Preview Ready

No new or changed pages found.

Copy link

pkg-pr-new bot commented Nov 14, 2024

npm i https://pkg.pr.new/@apollo/client@12131

commit: f30d83c

@jerelmiller
Copy link
Member Author

Here is the updated component with this change: apollographql/spotify-showcase@c630fa9

Much cleaner and required much less updating.

@jerelmiller jerelmiller added the 🎭 data-masking Issues/PRs related to data masking label Nov 15, 2024
@jerelmiller jerelmiller added this to the Data masking milestone Nov 15, 2024
@github-actions github-actions bot added the auto-cleanup 🤖 label Nov 15, 2024
Base automatically changed from jerel/fix-unmask-migrate-bug to release-3.12 November 15, 2024 17:30
@jerelmiller jerelmiller force-pushed the jerel/allow-null-in-usefragment branch from 94e0f01 to f30d83c Compare November 15, 2024 17:31
Copy link
Contributor

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 40.63 KB (+0.07% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 51.03 KB (+0.05% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 47.58 KB (+0.05% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 36.32 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 33.55 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.26 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.24 KB (0%)
import { useQuery } from "dist/react/index.js" 5.21 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.3 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.71 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.78 KB (0%)
import { useMutation } from "dist/react/index.js" 3.62 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.85 KB (0%)
import { useSubscription } from "dist/react/index.js" 4.43 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 3.48 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.51 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.17 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 5.01 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.66 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 5.09 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.74 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3.42 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 3.36 KB (0%)
import { useFragment } from "dist/react/index.js" 2.37 KB (+1.34% 🔺)
import { useFragment } from "dist/react/index.js" (production) 2.31 KB (+1.33% 🔺)

@jerelmiller jerelmiller merged commit 21c3f08 into release-3.12 Nov 15, 2024
41 of 45 checks passed
@jerelmiller jerelmiller deleted the jerel/allow-null-in-usefragment branch November 15, 2024 17:37
@github-actions github-actions bot mentioned this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-cleanup 🤖 🎭 data-masking Issues/PRs related to data masking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants