Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some codemod bugs #12126

Merged
merged 12 commits into from
Nov 14, 2024
Merged

Fix some codemod bugs #12126

merged 12 commits into from
Nov 14, 2024

Conversation

jerelmiller
Copy link
Member

While trying the codemod on the Spotify showcase repo, I found some bugs in the existing codemod. This fixes two issues:

  • If the document remains unchanged by the codemod (i.e. there are no fragment spreads to add @unmask to), keep it unchanged
  • Simplify the whitespace formatting. There were too many edge cases trying to maintain the original whitespace per-line from the original document since the print function removes whitespace-only lines. Instead this is replaced by indenting each line by the same amount, determine by how much the first non-whitespace character was indented.

Unfortunately the GraphQL printer cannot and does not handle comments, so these are always removed.

@svc-apollo-docs
Copy link

svc-apollo-docs commented Nov 13, 2024

✅ Docs Preview Ready

No new or changed pages found.

Copy link

changeset-bot bot commented Nov 13, 2024

🦋 Changeset detected

Latest commit: d004ca0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jerelmiller
Copy link
Member Author

Copy link

pkg-pr-new bot commented Nov 13, 2024

npm i https://pkg.pr.new/@apollo/client@12126

commit: b2f2884

Copy link
Contributor

github-actions bot commented Nov 13, 2024

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 40.6 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 50.98 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 47.56 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 36.31 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 33.56 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.26 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.24 KB (0%)
import { useQuery } from "dist/react/index.js" 5.21 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.3 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.71 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.78 KB (0%)
import { useMutation } from "dist/react/index.js" 3.62 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.85 KB (0%)
import { useSubscription } from "dist/react/index.js" 4.43 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 3.48 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.51 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.17 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 5.01 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.66 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 5.09 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.74 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3.42 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 3.36 KB (0%)
import { useFragment } from "dist/react/index.js" 2.33 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.28 KB (0%)

Copy link
Member

@phryneas phryneas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the examples folder, the results look good :)

@github-actions github-actions bot added the auto-cleanup 🤖 label Nov 14, 2024
@jerelmiller jerelmiller merged commit d10d702 into release-3.12 Nov 14, 2024
32 of 36 checks passed
@jerelmiller jerelmiller deleted the jerel/codemod-bugs branch November 14, 2024 16:39
@github-actions github-actions bot mentioned this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants