Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data masking] Add tests to ensure deferred payloads are masked #12114

Merged
merged 7 commits into from
Nov 8, 2024

Conversation

jerelmiller
Copy link
Member

Closes #12037

Adds tests to ensure data masking works with @defer payloads.

@jerelmiller jerelmiller added the 🎭 data-masking Issues/PRs related to data masking label Nov 8, 2024
@svc-apollo-docs
Copy link

svc-apollo-docs commented Nov 8, 2024

✅ Docs Preview Ready

No new or changed pages found.

Copy link

changeset-bot bot commented Nov 8, 2024

🦋 Changeset detected

Latest commit: 2bbbb40

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Nov 8, 2024

npm i https://pkg.pr.new/@apollo/client@12114

commit: 2bbbb40

@jerelmiller jerelmiller linked an issue Nov 8, 2024 that may be closed by this pull request
Copy link
Member

@phryneas phryneas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add one more test to show a mix of defer and unmask?

Approved as it is already :)

@github-actions github-actions bot added the auto-cleanup 🤖 label Nov 8, 2024
Base automatically changed from jerel/fix-test-after-merge to release-3.12 November 8, 2024 16:23
@jerelmiller
Copy link
Member Author

Good call! Will add one 🙂

@jerelmiller jerelmiller force-pushed the jerel/test-masked-defer-payloads branch from 9edb64f to ae5e4c5 Compare November 8, 2024 16:27
Copy link
Contributor

github-actions bot commented Nov 8, 2024

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 40.53 KB (+0.12% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 50.69 KB (+0.12% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 47.42 KB (+0.15% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 36.05 KB (+0.12% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 33.45 KB (+0.13% 🔺)
import { ApolloProvider } from "dist/react/index.js" 1.26 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.25 KB (0%)
import { useQuery } from "dist/react/index.js" 5.22 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.3 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.71 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.78 KB (0%)
import { useMutation } from "dist/react/index.js" 3.63 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.85 KB (0%)
import { useSubscription } from "dist/react/index.js" 4.43 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 3.48 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.51 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.17 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 5.02 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.66 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 5.09 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.74 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3.42 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 3.36 KB (0%)
import { useFragment } from "dist/react/index.js" 2.34 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.29 KB (0%)

@jerelmiller jerelmiller merged commit 1d4ce00 into release-3.12 Nov 8, 2024
40 of 45 checks passed
@jerelmiller jerelmiller deleted the jerel/test-masked-defer-payloads branch November 8, 2024 19:11
@github-actions github-actions bot mentioned this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-cleanup 🤖 🎭 data-masking Issues/PRs related to data masking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Data masking] Ensure data masking works with @defer payloads
3 participants