-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Suspense boundary indefinitely shown when fetchMore returns error #12110
Conversation
✅ Docs Preview ReadyNo new or changed pages found. |
🦋 Changeset detectedLatest commit: c4393ac The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
Fixes #12103
Fixes an issue where the Suspsense boundary would be shown indefinitely when
fetchMore
returned fromuseSuspenseQuery
is called and an error is returned.When using
fetchMore
, thehandleNext
function insideInternalQueryReference
was never called so there was no handler to resolve the promise thrown to the Suspense boundary. This small fix ensures thatreject
is called in.catch
so that the promise does not get stuck in pending.