-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix useSubscription restart was not cached #12044
Fix useSubscription restart was not cached #12044
Conversation
@DoctorJohn: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
🦋 Changeset detectedLatest commit: 5842753 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Great catch, thank you for the contribution! |
…estart-changed-every-render
This PR fixes that the
useSubscription
hook's definition of the recently added (#11927)restart
function was not cached between rerenders (unlikerefetch
andfetchMore
returned by similar hooks). This made therestart
function unsuitable to be included in the dependency array ofReact.useEffect
.My use case is restarting a subscription when a React Native app is resumed from the background. @phryneas I assume it's evident from the code that
restart
is redefined every render. However, if you would like a reproducible, please let me know.