-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to configure a name for the client for use with devtools #11936
Conversation
🦋 Changeset detectedLatest commit: 7a72e3f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the new option! :)
a83ccf2
to
e7631ca
Compare
Co-authored-by: Lenz Weber-Tronic <[email protected]>
e7631ca
to
882ff84
Compare
This PR adds the ability to specify a
name
for a client instance for use with devtools. This will be useful for the multiple clients feature to be able to more easily identify each client. Without this functionality, a randomly generated ID will be shown instead. Adding aname
makes this more human-friendly.As such, I've modified the way devtools is configured with the client by deprecating
connectToDevtools
and added a newdevtools
option:This is fully backwards compatible with
connectToDevtools
and will setenabled
totrue
if theconnectToDevtools
option is set. Structuring the config this way enables us to add additional functionality and configuration for the devtools in future versions without having to get creative with naming.This PR is missing updates to docs which will follow if we decide we like this change.