Skip to content

fix: initialFetchPolicy instead initialPolicy #11797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

yevmoroz
Copy link

@yevmoroz yevmoroz commented Apr 21, 2024

Fixing documentation for ApolloClient.defaultOptions.watchQuery.nextFetchPolicy custom function.
Considerations:

  • Context that is passed as second argument doesn't provide initialPolicy, but initialFetchPolicy:
  • Type definition raises error when initialPolicy is used
  • Search through code shows initialFetchPolicy is used in many places
  • initialPolicy is obsolete and not used at all

@yevmoroz yevmoroz requested a review from a team as a code owner April 21, 2024 01:36
@apollo-cla
Copy link

@yevmoroz: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Copy link

netlify bot commented Apr 21, 2024

👷 Deploy request for apollo-client-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 0408280

Copy link

changeset-bot bot commented Apr 21, 2024

⚠️ No Changeset found

Latest commit: 0408280

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@phryneas phryneas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - thank you for the PR!

@phryneas phryneas merged commit 45f7501 into apollographql:main Apr 22, 2024
30 of 31 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants