-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suspense cache: use Trie directly #10969
Conversation
🦋 Changeset detectedLatest commit: f75529d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great change! Thanks for recognizing this optimization! 🔥
Checklist:
I saw this and thought we could save some bundle size here by using Trie directly - with the downside that this is a bit harder to test.
@jerelmiller what are your thoughts on this? If you think this makes sense, I'll try to find a way to rewrite those failing tests.