More efficient implementation when conditionally stripping typename from variables

[jerelmiller]

#10853 introduced the ability to remove __typename from variables with an option to keep __typename at specific variable paths.

There was a question of whether we might be able to provide a more efficient way of handling this logic that would avoid the temporary array creation.

This PR introduces an alternate implementation that avoids some of the performance pitfalls of the initial implementation.

After running some benchmarks with a large data set (~2MB), this new implementation is about twice as fast as the old. Running this logic 5000 times with the old implementation took about 50s while the new implementation takes about 26s.

This PR also includes some additional tests for the removeTypenameFromVariables link that ensures it works with variables that do not include __typename.

Checklist:

• If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
• If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
• Make sure all of the significant new logic is covered by tests

[changeset-bot]

⚠️ No Changeset found

Latest commit: 359f80a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
dist/apollo-client.min.cjs	35.83 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs"	45.45 KB (-0.24% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js"	34.05 KB (0%)
import { ApolloProvider } from "dist/react/index.js"	1.05 KB (0%)
import { useQuery } from "dist/react/index.js"	4.55 KB (0%)
import { useLazyQuery } from "dist/react/index.js"	4.87 KB (0%)
import { useMutation } from "dist/react/index.js"	2.72 KB (0%)
import { useSubscription } from "dist/react/index.js"	2.55 KB (0%)
import { useSuspenseQuery_experimental } from "dist/react/index.js"	3.72 KB (0%)
import { useBackgroundQuery_experimental } from "dist/react/index.js"	3.15 KB (0%)
import { useReadQuery_experimental } from "dist/react/index.js"	1.25 KB (0%)
import { useFragment_experimental } from "dist/react/index.js"	1.98 KB (0%)

[benjamn]

I'm glad this idea ended up being worth pursuing! Thanks for following up on it @jerelmiller.