-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use optimism
0.17.4
#10888
Use optimism
0.17.4
#10888
Conversation
🦋 Changeset detectedLatest commit: 6b6d07b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
The size increase makes sense given the change to how the bundles were generated in 0.17.0 - we'll get these gains back as soon as the upstream fix lands. |
Instead of reverting, we should be able to upgrade shortly to avoid undoing/redoing changes in tests. Related PR: benjamn/optimism#548 |
/release:pr |
Please add a changeset via |
/release:pr |
A new release has been made for this PR. You can install it with |
optimism sourcemaps error is gone: https://codesandbox.io/s/beautiful-lucy-z82hul?file=/src/index.jsx 🎉 Edit: hmm, it's back... Still investigating. |
/release:pr |
A new release has been made for this PR. You can install it with |
/release:pr |
/release:pr |
A new release has been made for this PR. You can install it with |
Unfortunately, while these dependency bumps fix all sourcemap warnings, they don't solve the Codesandbox error. Still investigating. Edit: looks like a transpilation bug, more details: codesandbox/sandpack#940 |
/release:pr |
A new release has been made for this PR. You can install it with |
Closes #10856.
Unblocks use of alphas/snapshot releases from branches targeting
release-3.8
with Codesandbox - upstream workaround landed in[email protected]
.Checklist: