-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ESLint rule for consistent type imports #10852
Add ESLint rule for consistent type imports #10852
Conversation
🦋 Changeset detectedLatest commit: d56f26c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in favor of this change: there are the benefits you've mentioned, and the type
imports also make the code easier to grok at a glance 🎉
I talked to Ben yesterday, he's also on board with this. Waiting for input from Jerel on this, and I guess then I'll get this updated & merged :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dig it. Thank you!!
…-eslint/consistent-type-imports
We're only linting |
This will split up our
import
statements intoimport
andimport type
statements, which will hopefully make it easier for bundlers to work with our files, and might remove some accidental runtime import cross-dependencies that might have creeped into our packages.What do you think - should we do this?
Checklist: