Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix helm scripts BUG #4054

Merged
merged 1 commit into from
Oct 22, 2021
Merged

fix helm scripts BUG #4054

merged 1 commit into from
Oct 22, 2021

Conversation

w-a-n-g-s-h-u-n
Copy link
Contributor

@w-a-n-g-s-h-u-n w-a-n-g-s-h-u-n commented Oct 20, 2021 •
edited
Loading

What's the purpose of this PR

fix helm scripts BUG

Which issue(s) this PR fixes:

Fixes #

Brief changelog

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@github-actions
Copy link

github-actions bot commented Oct 20, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@nobodyiam nobodyiam mentioned this pull request Oct 21, 2021
Closed
@nobodyiam
Copy link
Member

@w-a-n-g-s-h-u-n thanks for the contribution! please sign the cla following the cla bot guides.

@codecov-commenter
Copy link

Codecov Report

Merging #4054 (5519f1e) into master (f132801) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4054      +/-   ##
============================================
+ Coverage     51.65%   51.67%   +0.02%     
+ Complexity     2547     2546       -1     
============================================
  Files           484      484              
  Lines         14844    14844              
  Branches       1536     1536              
============================================
+ Hits           7667     7671       +4     
+ Misses         6645     6640       -5     
- Partials        532      533       +1
Impacted Files Coverage Δ
.../apollo/internals/RemoteConfigLongPollService.java 77.10% <0.00%> (-1.21%) ⬇️
...mework/apollo/portal/component/PortalSettings.java 70.31% <0.00%> (+4.68%) ⬆️
...work/apollo/biz/message/DatabaseMessageSender.java 56.25% <0.00%> (+6.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f132801...5519f1e. Read the comment docs.

@w-a-n-g-s-h-u-n
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

nobodyiam
nobodyiam approved these changes Oct 22, 2021
View reviewed changes
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit cd34fdb into apolloconfig:master Oct 22, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2021
@nobodyiam nobodyiam added this to the 2.0.0 milestone Jan 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nobodyiam nobodyiam nobodyiam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@w-a-n-g-s-h-u-n @nobodyiam @codecov-commenter