Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proprosoal] Split helm chart into another repo #3959

Closed
JaredTan95 opened this issue Sep 8, 2021 · 6 comments · Fixed by #4126
Closed

[Proprosoal] Split helm chart into another repo #3959

JaredTan95 opened this issue Sep 8, 2021 · 6 comments · Fixed by #4126
Assignees
Milestone

Comments

@JaredTan95
Copy link
Member

Describe the solution you'd like
After discussed with @nobodyiam PMC member, we decided to split helm chart into another github repo, maybe like apollo-helm-chart or others.

Note:
Helm charts in the apolloconfig/apollo repo will remain in place for a period of time, and maintenance such as bug fixes and feature additions will be updated in the apollo-helm-chart repo.

@JaredTan95 JaredTan95 self-assigned this Sep 8, 2021
@JaredTan95 JaredTan95 added this to the 1.10.0 milestone Sep 8, 2021
@nobodyiam
Copy link
Member

shall we also move the apollo-on-kubernetes to the separate repo?

@JaredTan95
Copy link
Member Author

JaredTan95 commented Sep 10, 2021

I found out that If we want slipt helm-chart or apollo-on-kubernetes, we should release or provide docker image for helm/kubernetes deployment to pull image.

@JaredTan95
Copy link
Member Author

I found out that If we want slipt helm-chart or apollo-on-kubernetes, we should release or provide docker image for helm/kubernetes deployment to pull image.

ingore this,
because I found it in
https://github.com/apolloconfig/apollo/pull/3956/files#diff-58d193a961f6388b58a34096f2a1d5fa3cf8ebf3690ff4f57fccda88779aea14R83

@nobodyiam
Copy link
Member

There is one issue(#4054) related to the helm chart, I think we need to decide whether to split it or not.

@JaredTan95
Copy link
Member Author

Hi,

We have moved the helm chart into another repo. https://github.com/apolloconfig/apollo-helm-chart

@JaredTan95
Copy link
Member Author

shall we also move the apollo-on-kubernetes to the separate repo?

Seems other open source projects put native deployment yamls with code, unlike helm chart. For me, I'd like to hold apollo-on-kubernetes in apollo main repo. we can take a look at other committers' suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants