Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add i18n support and English translations #2641

Merged
merged 2 commits into from
Oct 8, 2019

Conversation

nobodyiam
Copy link
Member

No description provided.

@nobodyiam nobodyiam mentioned this pull request Oct 7, 2019
@nobodyiam nobodyiam added this to the 1.5.0 milestone Oct 7, 2019
@nobodyiam nobodyiam requested review from lepdou and JaredTan95 October 7, 2019 15:23
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 53.779% when pulling e2c71b5 on nobodyiam:i18n into f050e44 on ctripcorp:master.

@JaredTan95 JaredTan95 added backend feature Categorizes issue as related to a new feature. labels Oct 8, 2019
@JaredTan95
Copy link
Member

LGTM

The English translation new feature makes Apollo more professional.

image

image

@JaredTan95
Copy link
Member

We are going to merge this great feature.

FYI @czd890, and thanks for your contributions.

@codecov-io
Copy link

codecov-io commented Oct 8, 2019

Codecov Report

Merging #2641 into master will decrease coverage by <.01%.
The diff coverage is 9.09%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2641      +/-   ##
============================================
- Coverage     50.23%   50.22%   -0.01%     
  Complexity     2061     2061              
============================================
  Files           413      413              
  Lines         12647    12648       +1     
  Branches       1294     1294              
============================================
  Hits           6353     6353              
- Misses         5845     5846       +1     
  Partials        449      449
Impacted Files Coverage Δ Complexity Δ
.../com/ctrip/framework/apollo/common/dto/AppDTO.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../ctrip/framework/apollo/common/dto/ClusterDTO.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../framework/apollo/common/utils/InputValidator.java 88.88% <ø> (ø) 5 <0> (ø) ⬇️
...trip/framework/apollo/common/dto/NamespaceDTO.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...framework/apollo/portal/entity/model/AppModel.java 84.21% <ø> (ø) 11 <0> (ø) ⬇️
...p/framework/apollo/common/entity/AppNamespace.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...apollo/portal/controller/PermissionController.java 5.75% <0%> (ø) 1 <0> (ø) ⬇️
...amework/apollo/portal/util/RelativeDateFormat.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...pollo/openapi/v1/controller/ClusterController.java 20% <0%> (ø) 1 <0> (ø) ⬇️
...amework/apollo/common/controller/WebMvcConfig.java 0% <0%> (ø) 0 <0> (ø) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f050e44...e2c71b5. Read the comment docs.

@JaredTan95 JaredTan95 merged commit 437026f into apolloconfig:master Oct 8, 2019
nobodyiam added a commit to nobodyiam/apollo that referenced this pull request Oct 9, 2019
nobodyiam added a commit to nobodyiam/apollo that referenced this pull request Oct 9, 2019
nobodyiam added a commit that referenced this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Categorizes issue as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants