Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI多语言支持 #2452

Closed
wants to merge 16 commits into from
Closed

UI多语言支持 #2452

wants to merge 16 commits into from

Conversation

czd890
Copy link
Contributor

@czd890 czd890 commented Jul 17, 2019

image
image

  • 使用angular-translate.2.18.1作为多语言支持组件
  • 多语言文件在apollo-portal\src\main\resources\static\i18n文件夹中
  • 使用页面名称作为多语言key的前缀,通用的则用 Common

未完成:

  • 各个页面的翻译
  • 保存用户选择的语言到数据库

@codecov-io
Copy link

codecov-io commented Jul 17, 2019

Codecov Report

Merging #2452 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2452      +/-   ##
============================================
- Coverage     50.09%   50.07%   -0.03%     
  Complexity     2047     2047              
============================================
  Files           412      412              
  Lines         12586    12586              
  Branches       1289     1289              
============================================
- Hits           6305     6302       -3     
- Misses         5834     5836       +2     
- Partials        447      448       +1
Impacted Files Coverage Δ Complexity Δ
...lo/portal/spi/configuration/AuthConfiguration.java 5.78% <0%> (ø) 1 <0> (ø) ⬇️
...mework/apollo/portal/component/PortalSettings.java 65.07% <0%> (-4.77%) 5% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe28113...564bfe8. Read the comment docs.

@coveralls
Copy link

coveralls commented Jul 17, 2019

Coverage Status

Coverage decreased (-0.02%) to 53.631% when pulling 564bfe8 on czd890:multi-language into fe28113 on ctripcorp:master.

@nobodyiam
Copy link
Member

Looks promising!

@czd890 czd890 changed the title WIP: UI多语言支持 UI多语言支持 Aug 16, 2019
@czd890
Copy link
Contributor Author

czd890 commented Aug 16, 2019

@nobodyiam review一下,英文的翻译,用baidu api先走了一遍,资源文件中前200多个,英文比较ok的同事帮check了一下,省下的等check完了,在push上来。

@JaredTan95
Copy link
Member

I reviewed some UI in my local, it seems does not work well.

image

@czd890
Copy link
Contributor Author

czd890 commented Aug 16, 2019

@JaredTan95
I am running locally and it looks normal. Can you tell me what your browser is? It is best to open the developer tools to see if there are related errors.

@JaredTan95
Copy link
Member

@JaredTan95
I am running locally and it looks normal. Can you tell me what your browser is? It is best to open the developer tools to see if there are related errors.

Chrome in MacBook.

@nobodyiam
Copy link
Member

@czd890 看上去非常不错,👍

@JaredTan95 看下console,是不是有js报错或者静态文件没刷新导致的?

image

@nobodyiam nobodyiam requested a review from lepdou August 18, 2019 04:05
@nobodyiam nobodyiam added this to the 1.5.0 milestone Aug 25, 2019
@JaredTan95
Copy link
Member

@czd890 看上去非常不错,👍

@JaredTan95 看下console,是不是有js报错或者静态文件没刷新导致的?

image

确实是这样。重新开了一下,效果不错。👍

@nobodyiam
Copy link
Member

@nobodyiam review一下,英文的翻译,用baidu api先走了一遍,资源文件中前200多个,英文比较ok的同事帮check了一下,省下的等check完了,在push上来。

@czd890 大概什么时候可以check完都push上来?

@czd890
Copy link
Contributor Author

czd890 commented Sep 2, 2019

@nobodyiam 400/700了,然后同事休假去了(-_-),等她回来在搞搞还需要点时间。

@nobodyiam
Copy link
Member

nobodyiam commented Oct 7, 2019

@czd890

我基于你的分支对翻译内容作了一些修改,目前基本已经OK了,可以帮忙review一下,#2641

@JaredTan95
Copy link
Member

merged #2641.

@JaredTan95 JaredTan95 closed this Oct 8, 2019
@nobodyiam nobodyiam mentioned this pull request Dec 3, 2019
@czd890 czd890 deleted the multi-language branch July 21, 2021 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants