Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prometheus integration and fix the logout issue for ldap #2638

Merged
merged 1 commit into from
Oct 4, 2019

Conversation

nobodyiam
Copy link
Member

@nobodyiam nobodyiam added this to the 1.5.0 milestone Oct 4, 2019
@codecov-io
Copy link

codecov-io commented Oct 4, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@9636d5f). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2638   +/-   ##
=========================================
  Coverage          ?   50.23%           
  Complexity        ?     2061           
=========================================
  Files             ?      413           
  Lines             ?    12647           
  Branches          ?     1294           
=========================================
  Hits              ?     6353           
  Misses            ?     5845           
  Partials          ?      449
Impacted Files Coverage Δ Complexity Δ
...lo/portal/spi/configuration/AuthConfiguration.java 5.84% <0%> (ø) 1 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9636d5f...34e7833. Read the comment docs.

@coveralls
Copy link

coveralls commented Oct 4, 2019

Coverage Status

Coverage increased (+0.004%) to 53.784% when pulling 34e7833 on nobodyiam:ldap-fix into 9636d5f on ctripcorp:master.

@nobodyiam nobodyiam merged commit 7929a93 into apolloconfig:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants