Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prometheus integration. #2507

Merged
merged 5 commits into from
Aug 12, 2019
Merged

add prometheus integration. #2507

merged 5 commits into from
Aug 12, 2019

Conversation

JaredTan95
Copy link
Member

@JaredTan95 JaredTan95 commented Aug 8, 2019

support #2489

pom.xml Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Aug 11, 2019

Codecov Report

Merging #2507 into master will increase coverage by 8.32%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2507      +/-   ##
============================================
+ Coverage     50.19%   58.51%   +8.32%     
+ Complexity     2046     1174     -872     
============================================
  Files           410      196     -214     
  Lines         12555     5942    -6613     
  Branches       1285      636     -649     
============================================
- Hits           6302     3477    -2825     
+ Misses         5806     2204    -3602     
+ Partials        447      261     -186
Impacted Files Coverage Δ Complexity Δ
...amework/apollo/common/controller/WebMvcConfig.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../portal/spi/configuration/LdapGroupProperties.java
...ework/apollo/portal/controller/ItemController.java
...o/configservice/wrapper/DeferredResultWrapper.java
...omponent/emailbuilder/GrayPublishEmailBuilder.java
...k/apollo/portal/controller/FavoriteController.java
...apollo/portal/entity/vo/AppRolesAssignedUsers.java
...nfigservice/ConfigServerEurekaServerConfigure.java
...ponent/emailbuilder/NormalPublishEmailBuilder.java
.../framework/apollo/portal/entity/vo/SystemInfo.java
... and 204 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd231ab...0164bc3. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 53.76% when pulling d2afe49 on prometheus into fd231ab on master.

apollo-common/pom.xml Outdated Show resolved Hide resolved
apollo-common/pom.xml Outdated Show resolved Hide resolved
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants