Skip to content

MINOR: Refactor JmxTool and StreamsResetter to use CommandLineUtils#maybePrintHelpOrVersion #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
apalan60 wants to merge 8 commits into
base: trunk
Choose a base branch
from
Draft

MINOR: Refactor JmxTool and StreamsResetter to use CommandLineUtils#maybePrintHelpOrVersion #10

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
54abdcb
MINOR: Refactor JmxTool and StreamsResetter to use CommandLineUtils#m…
apalan60 Sep 3, 2025
ef10a52
KAFKA-19011 Improve EndToEndLatency Tool with argument parser and mes…
Rancho-7 Sep 3, 2025
7f09403
Address comments
apalan60 Sep 3, 2025
a9bce06
KAFKA-19535 add integration tests for DescribeProducersOptions#broker…
apalan60 Sep 3, 2025
ea5b5fe
KAFKA-19432 Add an ERROR log message if broker.heartbeat.interval.ms …
FrankYang0529 Sep 3, 2025
c3af206
MINOR: code cleanup (#20455)
mjsax Sep 4, 2025
6097b33
MINOR: Update supported image tags in docker_scan (#20459)
mimaison Sep 4, 2025
0503553
Merge remote-tracking branch 'upstream/trunk' into MINOR
apalan60 Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions tools/src/main/java/org/apache/kafka/tools/JmxTool.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,7 @@ public class JmxTool {
public static void main(String[] args) {
try {
JmxToolOptions options = new JmxToolOptions(args);
if (CommandLineUtils.isPrintHelpNeeded(options)) {
CommandLineUtils.printUsageAndExit(options.parser, "Dump JMX values to standard output.");
return;
}
if (CommandLineUtils.isPrintVersionNeeded(options)) {
CommandLineUtils.printVersionAndExit();
return;
}
CommandLineUtils.maybePrintHelpOrVersion(options, "Dump JMX values to standard output.");

Optional<String[]> attributesInclude = options.attributesInclude();
Optional<DateFormat> dateFormat = options.dateFormat();
Expand Down
7 changes: 1 addition & 6 deletions tools/src/main/java/org/apache/kafka/tools/StreamsResetter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,12 +647,7 @@ public StreamsResetterOptions(String[] args) {

try {
options = parser.parse(args);
if (CommandLineUtils.isPrintHelpNeeded(this)) {
CommandLineUtils.printUsageAndExit(parser, USAGE);
}
if (CommandLineUtils.isPrintVersionNeeded(this)) {
CommandLineUtils.printVersionAndExit();
}
CommandLineUtils.maybePrintHelpOrVersion(this, USAGE);
CommandLineUtils.checkInvalidArgs(parser, options, toOffsetOption, toDatetimeOption, byDurationOption, toEarliestOption, toLatestOption, fromFileOption, shiftByOption);
CommandLineUtils.checkInvalidArgs(parser, options, toDatetimeOption, toOffsetOption, byDurationOption, toEarliestOption, toLatestOption, fromFileOption, shiftByOption);
CommandLineUtils.checkInvalidArgs(parser, options, byDurationOption, toOffsetOption, toDatetimeOption, toEarliestOption, toLatestOption, fromFileOption, shiftByOption);
Expand Down