MINOR: Refactor JmxTool and StreamsResetter to use CommandLineUtils#maybePrintHelpOrVersion

[apalan60]

No description provided.

[apalan60]

/review
--pr_reviewer.extra_instructions="
In the possible issues section, emphasize the following:

• Is the code logic efficient?

"
--pr_reviewer.inline_code_comments=true
-i
--pr_reviewer.require_can_be_split_review=true
--pr_reviewer.num_code_suggestions="5"

[apalan60]

/describe
--pr_description.publish_description_as_comment=true
--pr_description.generate_ai_title=true

[apalan60]

/improve
--pr_code_suggestions.extra_instructions="
Emphasize the following:

• Does the code logic cover relevant edge cases?
• Is the code logic clear and easy to understand?
• Is the code logic efficient?

"
--pr_code_suggestions.num_code_suggestions_per_chunk="4"
--pr_code_suggestions.commitable_code_suggestions=true
--pr_code_suggestions.suggestions_score_threshold="0"

[qodo-code-review]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

🔀 Multiple PR themes Sub-PR theme: Refactor JmxTool to use CommandLineUtils.maybePrintHelpOrVersion Relevant files: tools/src/main/java/org/apache/kafka/tools/JmxTool.java Sub-PR theme: Refactor StreamsResetter to use CommandLineUtils.maybePrintHelpOrVersion and validate argument checks Relevant files: tools/src/main/java/org/apache/kafka/tools/StreamsResetter.java

⚡ Recommended focus areas for review Efficiency The same invalid-args check is performed four times with different primary arguments; verify whether these repeated calls are required by design. If not, consider consolidating to avoid redundant work at startup. CommandLineUtils.checkInvalidArgs(parser, options, toOffsetOption, toDatetimeOption, byDurationOption, toEarliestOption, toLatestOption, fromFileOption, shiftByOption); CommandLineUtils.checkInvalidArgs(parser, options, toDatetimeOption, toOffsetOption, byDurationOption, toEarliestOption, toLatestOption, fromFileOption, shiftByOption); CommandLineUtils.checkInvalidArgs(parser, options, byDurationOption, toOffsetOption, toDatetimeOption, toEarliestOption, toLatestOption, fromFileOption, shiftByOption); CommandLineUtils.checkInvalidArgs(parser, options, toEarliestOption, toOffsetOption, toDatetimeOption, byDurationOption, toLatestOption, fromFileOption, shiftByOption); Behavior Change Replacing explicit help/version handling with a utility method may alter exit codes or side effects; confirm parity with previous behavior and that options conforms to the utility’s expectations. CommandLineUtils.maybePrintHelpOrVersion(options, "Dump JMX values to standard output.");

[apalan60]

/gemini review

[qodo-code-review]

Title

Refactor command-line tools to use centralized help/version handling

---

PR Type

Other

---

Description

• Refactor help and version handling in command-line tools

• Replace duplicate code with centralized utility method

• Simplify conditional logic in JmxTool and StreamsResetter

---

Diagram Walkthrough

flowchart LR
  A["JmxTool.main()"] --> B["CommandLineUtils.maybePrintHelpOrVersion()"]
  C["StreamsResetter constructor"] --> B
  B --> D["Centralized help/version logic"]

Loading

File Walkthrough

Relevant files

Enhancement

JmxTool.java Simplify help/version handling in JmxTool                                tools/src/main/java/org/apache/kafka/tools/JmxTool.java Replace separate help and version checks with single utility call Remove 8 lines of duplicate conditional logic Maintain same functionality with cleaner code +1/-8      StreamsResetter.java Simplify help/version handling in StreamsResetter                tools/src/main/java/org/apache/kafka/tools/StreamsResetter.java Replace separate help and version checks with single utility call Remove 6 lines of duplicate conditional logic Streamline constructor initialization flow +1/-6

---

[qodo-code-review]

PR Code Suggestions ✨

No code suggestions found for the PR.

[gemini-code-assist]

Code Review

This pull request refactors JmxTool and StreamsResetter to use the CommandLineUtils#maybePrintHelpOrVersion utility method. This change correctly simplifies the command-line argument parsing logic for handling --help and --version flags, replacing boilerplate code with a single method call. The refactoring improves code readability and maintainability by reducing duplication. The changes are well-implemented and I have no further suggestions.