Fix navigation link of documentation for storage using anchor. #999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Remove unnecessary spaces.
…. Remove unnecessary spaces.
# Conflicts: # docs/interpreter/cassandra.md
# Conflicts: # docs/interpreter/cassandra.md
# Conflicts: # docs/interpreter/cassandra.md
# Conflicts: # docs/interpreter/cassandra.md # docs/interpreter/spark.md # docs/manual/interpreters.md
# Conflicts: # docs/security/authentication.md
# Conflicts: # dev/merge_zeppelin_pr.py # docs/quickstart/explorezeppelinui.md # zeppelin-server/src/main/java/org/apache/zeppelin/rest/LoginRestApi.java # zeppelin-web/.jshintrc # zeppelin-web/src/app/notebook/notebook.controller.js # zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js # zeppelin-web/src/components/navbar/navbar.controller.js # zeppelin-web/src/components/navbar/navbar.html
# Conflicts: # docs/assets/themes/zeppelin/js/docs.js
Member
Contributor
Author
|
@minahlee No problem :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
In documentation about storage, a custom hashtag navigation used to nav to each paragraph but scrolling is not working properly (it cannot fully scroll to headers of paragraph) when clicking each menu at nav bar.
But after PR #995 by @AhyoungRyu, custom hashtag nav can be changed into anchor.js style so I fixed nav for documentation to use this anchor feature to make it scroll properly.
What type of PR is it?
Bug Fix, Documentation
Todos
How should this be tested?
Screenshots (if appropriate)
Questions: