-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[ZEPPELIN-996] Improve first page and dropdown menu in documentation site #1004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Great work, |
|
@corneadoug Ah there is two menu actually, they are not shown properly in the screenshot.
Anyway, I can change the placement as you suggested :) |
|
Oh indeed, |
|
@corneadoug Yeah you're right and it makes sense indeed. I addressed it :) |
| {% include JB/setup %} | ||
| ## Html | ||
|
|
||
| With `%html` directive, Zeppelin treats your output as html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nitpick - it's probably 'as HTML' capital case, as it's referred below
|
This is what I see from my screen, and cannot scroll down lower. Can you adjust size of the dropdown menu? And also, can we rollback the change of display system menu order to text -> html -> table? if there are a lot of menu then alphabetical order makes sense, but in this case I think better to display in order of basic to advanced Other than above comments, this PR looks awesome! |
|
merging if there is no more discussion |
### What is this PR for? In Zeppelin docs website, there are 4 dropdown menus(Quick Start, Interpreters, Display System and More) in the navbar. Especially **Interpreters** and **More** menu have lots of lists so I made this dropdown menu scrollable in #1004. Originally the scroll bar is shown up when a user is trying to scroll down. That's why it's hard to notice there are more menus in the dropdown menu. See [this issue](https://issues.apache.org/jira/browse/ZEPPELIN-1085). So I made this scroll bar always visible. But only for chrome & safari. Unfortunately, Firefox doesn't support custom scroll bar. See [here](http://stackoverflow.com/questions/18317634/force-visible-scrollbar-in-firefox-on-mac-os-x). In short, it says >There is no way to actually "force" Firefox render the old-style scrollbar since the default scrollbar used in the system is predefined by the OS itself (note that you can modify which scrollbar you want in System Preferences). ### What type of PR is it? Improvement ### TODO - [x] : test this in major browsers ### What is the Jira issue? [ZEPPELIN-1085](https://issues.apache.org/jira/browse/ZEPPELIN-1085) ### How should this be tested? [Build the Zeppelin docs website](https://github.com/apache/zeppelin/tree/master/docs#build-documentation) in your local and check the dropdown menu in navbar. The scrollbae has to be shown right after you click **Interpreters** or **More** menu. ### Screenshots (if appropriate) - Before : scrollbar is only shown up when you are trying to scroll up & down  - After : always visible  - In case of IE, you can always see the scrollbar. So it's not a problem originally.  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: AhyoungRyu <[email protected]> Closes #1143 from AhyoungRyu/ZEPPELIN-1085 and squashes the following commits: 4d10883 [AhyoungRyu] Make dropdown menu scrollbar always visible
### What is this PR for? In Zeppelin docs website, there are 4 dropdown menus(Quick Start, Interpreters, Display System and More) in the navbar. Especially **Interpreters** and **More** menu have lots of lists so I made this dropdown menu scrollable in #1004. Originally the scroll bar is shown up when a user is trying to scroll down. That's why it's hard to notice there are more menus in the dropdown menu. See [this issue](https://issues.apache.org/jira/browse/ZEPPELIN-1085). So I made this scroll bar always visible. But only for chrome & safari. Unfortunately, Firefox doesn't support custom scroll bar. See [here](http://stackoverflow.com/questions/18317634/force-visible-scrollbar-in-firefox-on-mac-os-x). In short, it says >There is no way to actually "force" Firefox render the old-style scrollbar since the default scrollbar used in the system is predefined by the OS itself (note that you can modify which scrollbar you want in System Preferences). ### What type of PR is it? Improvement ### TODO - [x] : test this in major browsers ### What is the Jira issue? [ZEPPELIN-1085](https://issues.apache.org/jira/browse/ZEPPELIN-1085) ### How should this be tested? [Build the Zeppelin docs website](https://github.com/apache/zeppelin/tree/master/docs#build-documentation) in your local and check the dropdown menu in navbar. The scrollbae has to be shown right after you click **Interpreters** or **More** menu. ### Screenshots (if appropriate) - Before : scrollbar is only shown up when you are trying to scroll up & down  - After : always visible  - In case of IE, you can always see the scrollbar. So it's not a problem originally.  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: AhyoungRyu <[email protected]> Closes #1143 from AhyoungRyu/ZEPPELIN-1085 and squashes the following commits: 4d10883 [AhyoungRyu] Make dropdown menu scrollbar always visible (cherry picked from commit 1ccbd60) Signed-off-by: Mina Lee <[email protected]>
### What is this PR for? In Zeppelin docs website, there are 4 dropdown menus(Quick Start, Interpreters, Display System and More) in the navbar. Especially **Interpreters** and **More** menu have lots of lists so I made this dropdown menu scrollable in apache#1004. Originally the scroll bar is shown up when a user is trying to scroll down. That's why it's hard to notice there are more menus in the dropdown menu. See [this issue](https://issues.apache.org/jira/browse/ZEPPELIN-1085). So I made this scroll bar always visible. But only for chrome & safari. Unfortunately, Firefox doesn't support custom scroll bar. See [here](http://stackoverflow.com/questions/18317634/force-visible-scrollbar-in-firefox-on-mac-os-x). In short, it says >There is no way to actually "force" Firefox render the old-style scrollbar since the default scrollbar used in the system is predefined by the OS itself (note that you can modify which scrollbar you want in System Preferences). ### What type of PR is it? Improvement ### TODO - [x] : test this in major browsers ### What is the Jira issue? [ZEPPELIN-1085](https://issues.apache.org/jira/browse/ZEPPELIN-1085) ### How should this be tested? [Build the Zeppelin docs website](https://github.com/apache/zeppelin/tree/master/docs#build-documentation) in your local and check the dropdown menu in navbar. The scrollbae has to be shown right after you click **Interpreters** or **More** menu. ### Screenshots (if appropriate) - Before : scrollbar is only shown up when you are trying to scroll up & down  - After : always visible  - In case of IE, you can always see the scrollbar. So it's not a problem originally.  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: AhyoungRyu <[email protected]> Closes apache#1143 from AhyoungRyu/ZEPPELIN-1085 and squashes the following commits: 4d10883 [AhyoungRyu] Make dropdown menu scrollbar always visible
### What is this PR for? I added available interpreters' logo image to `index.md` by #1004. So I updated this outdated `available_interpreters.png` for [BigQuery](https://cloud.google.com/bigquery/) & [Livy](http://livy.io/) logo. ### What type of PR is it? Improvement ### What is the Jira issue? Since it's just for `available_interpreters.png` update, didn't create Jira issue for this. ### Screenshots (if appropriate) - Before <img width="801" alt="screen shot 2016-08-18 at 4 45 01 pm" src="https://cloud.githubusercontent.com/assets/10060731/17765940/9783fd9a-6563-11e6-95e6-20b400209d80.png"> - After  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: AhyoungRyu <[email protected]> Closes #1340 from AhyoungRyu/update/availableInterpreterPic and squashes the following commits: 8839b97 [AhyoungRyu] Change available interpreters' list to alphabetical order 83206b8 [AhyoungRyu] Update available interpreters logo image in index.md
### What is this PR for? I added available interpreters' logo image to `index.md` by #1004. So I updated this outdated `available_interpreters.png` for [BigQuery](https://cloud.google.com/bigquery/) & [Livy](http://livy.io/) logo. ### What type of PR is it? Improvement ### What is the Jira issue? Since it's just for `available_interpreters.png` update, didn't create Jira issue for this. ### Screenshots (if appropriate) - Before <img width="801" alt="screen shot 2016-08-18 at 4 45 01 pm" src="https://cloud.githubusercontent.com/assets/10060731/17765940/9783fd9a-6563-11e6-95e6-20b400209d80.png"> - After  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: AhyoungRyu <[email protected]> Closes #1340 from AhyoungRyu/update/availableInterpreterPic and squashes the following commits: 8839b97 [AhyoungRyu] Change available interpreters' list to alphabetical order 83206b8 [AhyoungRyu] Update available interpreters logo image in index.md (cherry picked from commit ce56188) Signed-off-by: Mina Lee <[email protected]>



What is this PR for?
Current Zeppelin documentation site is little bit hard to find a way for Zeppelin beginners. It will not easy to improve this at a time, but I did the below as a start of this work.
Please see the attached screenshot images :)
What type of PR is it?
Improvement & Documentation
Todos
text.md,table.mdandhtml.mdtobasicdisplaysystem.mdvirtual_machine.mdindex.md)What is the Jira issue?
ZEPPELIN-996
How should this be tested?
Screenshots (if appropriate)
Questions: