Skip to content

Conversation

@AhyoungRyu
Copy link
Contributor

@AhyoungRyu AhyoungRyu commented Jun 13, 2016

What is this PR for?

Current Zeppelin documentation site is little bit hard to find a way for Zeppelin beginners. It will not easy to improve this at a time, but I did the below as a start of this work.

  1. Restructured dropdown menu and added each category names
  2. Added a overview list(with short description) to first page of website (index.md) so that people can look through the overall contents in Zeppelin website at a glance. (as Apache Spark and Apache Mesos does)

Please see the attached screenshot images :)

What type of PR is it?

Improvement & Documentation

Todos

What is the Jira issue?

ZEPPELIN-996

How should this be tested?

  1. Apply this patch and build the docs website with jekyll
  2. Check the first page(index.html) and dropdown menu

Screenshots (if appropriate)

  • Dropdown menu
    dropdown
  • First page
    screen shot 2016-06-14 at 1 28 58 pm
    screen shot 2016-06-14 at 1 29 11 pm
    screen shot 2016-06-14 at 1 29 39 pm
    screen shot 2016-06-14 at 1 29 57 pm
    screen shot 2016-06-14 at 1 30 12 pm
    screen shot 2016-06-14 at 1 30 22 pm

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@AhyoungRyu AhyoungRyu changed the title Improve first page and dropdown menu in documentation site [ZEPPELIN-996] Improve first page and dropdown menu in documentation site Jun 13, 2016
@corneadoug
Copy link
Contributor

Great work,
Maybe in the case of the interpreter menu, we should bring the usage section before the available interpeters (since there is only one item)

@AhyoungRyu
Copy link
Contributor Author

@corneadoug Ah there is two menu actually, they are not shown properly in the screenshot.

  • Dynamic Interpreter Loading
  • Dependency Management

Anyway, I can change the placement as you suggested :)

@corneadoug
Copy link
Contributor

Oh indeed,
Since they are more generalistic and also a but hidden down there, it could be a better read flow to have them right below the overview

@AhyoungRyu
Copy link
Contributor Author

@corneadoug Yeah you're right and it makes sense indeed. I addressed it :)

{% include JB/setup %}
## Html

With `%html` directive, Zeppelin treats your output as html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nitpick - it's probably 'as HTML' capital case, as it's referred below

@AhyoungRyu
Copy link
Contributor Author

@bzz Thanks for your prudent review! I just addressed them in 6a2f40b.

@minahlee
Copy link
Member

screen shot 2016-06-14 at 10 34 51 am

This is what I see from my screen, and cannot scroll down lower. Can you adjust size of the dropdown menu?

And also, can we rollback the change of display system menu order to text -> html -> table? if there are a lot of menu then alphabetical order makes sense, but in this case I think better to display in order of basic to advanced

Other than above comments, this PR looks awesome!

@AhyoungRyu
Copy link
Contributor Author

AhyoungRyu commented Jun 14, 2016

@minahlee Thanks for your prudent feedback! I just addressed them to my last some commits as you said. And I also applied scrollbar to "More" tab.

BTW, I found an UI issue on "More" tab. When the screen width is small, some long text in the list are not visible. It was also fixed at af70939

  • Before
    screen shot 2016-06-14 at 1 36 10 pm
  • After
    screen shot 2016-06-14 at 1 36 58 pm

@minahlee
Copy link
Member

merging if there is no more discussion

@asfgit asfgit closed this in 5ddc1ef Jun 15, 2016
asfgit pushed a commit that referenced this pull request Jul 9, 2016
### What is this PR for?
In Zeppelin docs website, there are 4 dropdown menus(Quick Start, Interpreters, Display System and More) in the navbar. Especially **Interpreters** and **More** menu have lots of lists so I made this dropdown menu scrollable in #1004.
Originally the scroll bar is shown up when  a user is trying to scroll down. That's why it's hard to notice there are more menus in the dropdown menu.  See [this issue](https://issues.apache.org/jira/browse/ZEPPELIN-1085).

So I made this scroll bar always visible. But only for chrome & safari. Unfortunately, Firefox doesn't support custom scroll bar. See [here](http://stackoverflow.com/questions/18317634/force-visible-scrollbar-in-firefox-on-mac-os-x).
In short, it says
>There is no way to actually "force" Firefox render the old-style scrollbar since the default scrollbar used in the system is predefined by the OS itself (note that you can modify which scrollbar you want in System Preferences).

### What type of PR is it?
Improvement

### TODO
- [x] : test this in major browsers

### What is the Jira issue?
[ZEPPELIN-1085](https://issues.apache.org/jira/browse/ZEPPELIN-1085)

### How should this be tested?
[Build the Zeppelin docs website](https://github.com/apache/zeppelin/tree/master/docs#build-documentation) in your local and check the dropdown menu in navbar. The scrollbae has to be shown right after you click **Interpreters** or **More** menu.

### Screenshots (if appropriate)
 - Before : scrollbar is only shown up when you are trying to scroll up & down
![before](https://cloud.githubusercontent.com/assets/10060731/16647507/8c6fbc60-446a-11e6-9a57-b00a76e6b59c.gif)

 - After : always visible
![after](https://cloud.githubusercontent.com/assets/10060731/16647513/901e4e3a-446a-11e6-840b-599b6121fe46.gif)

 - In case of IE, you can always see the scrollbar. So it's not a problem originally.
![screen shot 2016-07-07 at 5 41 27 pm](https://cloud.githubusercontent.com/assets/10060731/16647584/e3708ff8-446a-11e6-8aee-c03eaba70cc9.png)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: AhyoungRyu <[email protected]>

Closes #1143 from AhyoungRyu/ZEPPELIN-1085 and squashes the following commits:

4d10883 [AhyoungRyu] Make dropdown menu scrollbar always visible
asfgit pushed a commit that referenced this pull request Jul 18, 2016
### What is this PR for?
In Zeppelin docs website, there are 4 dropdown menus(Quick Start, Interpreters, Display System and More) in the navbar. Especially **Interpreters** and **More** menu have lots of lists so I made this dropdown menu scrollable in #1004.
Originally the scroll bar is shown up when  a user is trying to scroll down. That's why it's hard to notice there are more menus in the dropdown menu.  See [this issue](https://issues.apache.org/jira/browse/ZEPPELIN-1085).

So I made this scroll bar always visible. But only for chrome & safari. Unfortunately, Firefox doesn't support custom scroll bar. See [here](http://stackoverflow.com/questions/18317634/force-visible-scrollbar-in-firefox-on-mac-os-x).
In short, it says
>There is no way to actually "force" Firefox render the old-style scrollbar since the default scrollbar used in the system is predefined by the OS itself (note that you can modify which scrollbar you want in System Preferences).

### What type of PR is it?
Improvement

### TODO
- [x] : test this in major browsers

### What is the Jira issue?
[ZEPPELIN-1085](https://issues.apache.org/jira/browse/ZEPPELIN-1085)

### How should this be tested?
[Build the Zeppelin docs website](https://github.com/apache/zeppelin/tree/master/docs#build-documentation) in your local and check the dropdown menu in navbar. The scrollbae has to be shown right after you click **Interpreters** or **More** menu.

### Screenshots (if appropriate)
 - Before : scrollbar is only shown up when you are trying to scroll up & down
![before](https://cloud.githubusercontent.com/assets/10060731/16647507/8c6fbc60-446a-11e6-9a57-b00a76e6b59c.gif)

 - After : always visible
![after](https://cloud.githubusercontent.com/assets/10060731/16647513/901e4e3a-446a-11e6-840b-599b6121fe46.gif)

 - In case of IE, you can always see the scrollbar. So it's not a problem originally.
![screen shot 2016-07-07 at 5 41 27 pm](https://cloud.githubusercontent.com/assets/10060731/16647584/e3708ff8-446a-11e6-8aee-c03eaba70cc9.png)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: AhyoungRyu <[email protected]>

Closes #1143 from AhyoungRyu/ZEPPELIN-1085 and squashes the following commits:

4d10883 [AhyoungRyu] Make dropdown menu scrollbar always visible

(cherry picked from commit 1ccbd60)
Signed-off-by: Mina Lee <[email protected]>
PhilippGrulich pushed a commit to SWC-SENSE/zeppelin that referenced this pull request Aug 8, 2016
### What is this PR for?
In Zeppelin docs website, there are 4 dropdown menus(Quick Start, Interpreters, Display System and More) in the navbar. Especially **Interpreters** and **More** menu have lots of lists so I made this dropdown menu scrollable in apache#1004.
Originally the scroll bar is shown up when  a user is trying to scroll down. That's why it's hard to notice there are more menus in the dropdown menu.  See [this issue](https://issues.apache.org/jira/browse/ZEPPELIN-1085).

So I made this scroll bar always visible. But only for chrome & safari. Unfortunately, Firefox doesn't support custom scroll bar. See [here](http://stackoverflow.com/questions/18317634/force-visible-scrollbar-in-firefox-on-mac-os-x).
In short, it says
>There is no way to actually "force" Firefox render the old-style scrollbar since the default scrollbar used in the system is predefined by the OS itself (note that you can modify which scrollbar you want in System Preferences).

### What type of PR is it?
Improvement

### TODO
- [x] : test this in major browsers

### What is the Jira issue?
[ZEPPELIN-1085](https://issues.apache.org/jira/browse/ZEPPELIN-1085)

### How should this be tested?
[Build the Zeppelin docs website](https://github.com/apache/zeppelin/tree/master/docs#build-documentation) in your local and check the dropdown menu in navbar. The scrollbae has to be shown right after you click **Interpreters** or **More** menu.

### Screenshots (if appropriate)
 - Before : scrollbar is only shown up when you are trying to scroll up & down
![before](https://cloud.githubusercontent.com/assets/10060731/16647507/8c6fbc60-446a-11e6-9a57-b00a76e6b59c.gif)

 - After : always visible
![after](https://cloud.githubusercontent.com/assets/10060731/16647513/901e4e3a-446a-11e6-840b-599b6121fe46.gif)

 - In case of IE, you can always see the scrollbar. So it's not a problem originally.
![screen shot 2016-07-07 at 5 41 27 pm](https://cloud.githubusercontent.com/assets/10060731/16647584/e3708ff8-446a-11e6-8aee-c03eaba70cc9.png)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: AhyoungRyu <[email protected]>

Closes apache#1143 from AhyoungRyu/ZEPPELIN-1085 and squashes the following commits:

4d10883 [AhyoungRyu] Make dropdown menu scrollbar always visible
asfgit pushed a commit that referenced this pull request Aug 24, 2016
### What is this PR for?
I added available interpreters' logo image to `index.md` by #1004. So I updated this outdated `available_interpreters.png` for [BigQuery](https://cloud.google.com/bigquery/) & [Livy](http://livy.io/) logo.

### What type of PR is it?
Improvement

### What is the Jira issue?
Since it's just for `available_interpreters.png` update, didn't create Jira issue for this.

### Screenshots (if appropriate)
 - Before
<img width="801" alt="screen shot 2016-08-18 at 4 45 01 pm" src="https://cloud.githubusercontent.com/assets/10060731/17765940/9783fd9a-6563-11e6-95e6-20b400209d80.png">

 - After
![screen shot 2016-08-22 at 5 23 50 pm](https://cloud.githubusercontent.com/assets/10060731/17848287/8969a214-688d-11e6-9c00-b8371c836514.png)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: AhyoungRyu <[email protected]>

Closes #1340 from AhyoungRyu/update/availableInterpreterPic and squashes the following commits:

8839b97 [AhyoungRyu] Change available interpreters' list to alphabetical order
83206b8 [AhyoungRyu] Update available interpreters logo image in index.md
asfgit pushed a commit that referenced this pull request Aug 24, 2016
### What is this PR for?
I added available interpreters' logo image to `index.md` by #1004. So I updated this outdated `available_interpreters.png` for [BigQuery](https://cloud.google.com/bigquery/) & [Livy](http://livy.io/) logo.

### What type of PR is it?
Improvement

### What is the Jira issue?
Since it's just for `available_interpreters.png` update, didn't create Jira issue for this.

### Screenshots (if appropriate)
 - Before
<img width="801" alt="screen shot 2016-08-18 at 4 45 01 pm" src="https://cloud.githubusercontent.com/assets/10060731/17765940/9783fd9a-6563-11e6-95e6-20b400209d80.png">

 - After
![screen shot 2016-08-22 at 5 23 50 pm](https://cloud.githubusercontent.com/assets/10060731/17848287/8969a214-688d-11e6-9c00-b8371c836514.png)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: AhyoungRyu <[email protected]>

Closes #1340 from AhyoungRyu/update/availableInterpreterPic and squashes the following commits:

8839b97 [AhyoungRyu] Change available interpreters' list to alphabetical order
83206b8 [AhyoungRyu] Update available interpreters logo image in index.md

(cherry picked from commit ce56188)
Signed-off-by: Mina Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants