Skip to content

Conversation

@Leemoonsoo
Copy link
Member

What is this PR for?

This PR apply fix #769 again, which is reverted by #208.
Also removing unnecessary code from interpreter.sh

What type of PR is it?

Bug Fix

Todos

What is the Jira issue?

How should this be tested?

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@felixcheung
Copy link
Member

LGTM

@elbamos
Copy link
Contributor

elbamos commented May 13, 2016

It takes out a change I'd out there because the r interpreter jar wasn't getting loaded in time in some circumstances. I need to test this. I will try to do that in the next few days.

On May 12, 2016, at 11:08 AM, Lee moon soo [email protected] wrote:

What is this PR for?

This PR apply fix #769 again, which is reverted by #208.
Also removing unnecessary code from interpreter.sh

What type of PR is it?

Bug Fix

Todos

How should this be tested?

Screenshots (if appropriate)

Questions:

Does the licenses files need update? no
Is there breaking changes for older versions? no
Does this needs documentation? no
You can view, comment on, or merge this pull request online at:

#889

Commit Summary

Apply pr769 again, reverted by pr208
Remove unnecessary construction of classpath
File Changes

M bin/interpreter.sh (7)
Patch Links:

https://github.com/apache/incubator-zeppelin/pull/889.patch
https://github.com/apache/incubator-zeppelin/pull/889.diff

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub

@Leemoonsoo
Copy link
Member Author

Every jar under interpreter/spark/ supposed to be included in the classpath by interpreter.sh#67. So i expect this PR does not change any behavior. @elbamos if you find any case that jar is not loaded in this way, please file an issue.

Merge if there're no more discussions.

@asfgit asfgit closed this in fb4a76a May 19, 2016
shijinkui pushed a commit to shijinkui/incubator-zeppelin that referenced this pull request May 26, 2016
### What is this PR for?
This PR apply fix apache#769 again, which is reverted by apache#208.
Also removing unnecessary code from interpreter.sh

### What type of PR is it?
Bug Fix

### Todos
* [x] - Apply apache#769 again
* [x] - Remove unnecessary code

### What is the Jira issue?

### How should this be tested?

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: Lee moon soo <[email protected]>

Closes apache#889 from Leemoonsoo/fix_interpreter_sh_classpath and squashes the following commits:

8468fd5 [Lee moon soo] Remove unnecessary construction of classpath
ea8fee8 [Lee moon soo] Apply pr769 again, reverted by pr208
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants