-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Fix interpreter.sh to get Spark interpreter log file #769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Good catch 👍 |
Member
|
LGTM. merging if no more comment |
3 tasks
fireboy1919
pushed a commit
to fireboy1919/incubator-zeppelin
that referenced
this pull request
Apr 5, 2016
### What is this PR for? Currently, if users set their own `SPARK_HOME`, they can not get `zeppelin-interpreter-spark-xxxx.log` file. This PR is for fixing this issue. (This issue is reported by weipuz) ### What type of PR is it? Hot Fix ### Todos ### What is the Jira issue? None ### How should this be tested? After applying this PR, 1. Set your own `SPARK_HOME`. 2. Run `sc.version`(or whatever you want) with Spark interpreter. 3. Check under your `ZEPPELIN_HOME/logs/` directory, then you can find `zeppelin-interpreter-spark-xxx.log` file. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: AhyoungRyu <[email protected]> Closes apache#769 from AhyoungRyu/fix-spark-log and squashes the following commits: dcdad56 [AhyoungRyu] Ping travis 8564f8c [AhyoungRyu] Fix interpreter.sh to get Spark interpreter log
onkarshedge
pushed a commit
to onkarshedge/incubator-zeppelin
that referenced
this pull request
May 11, 2016
### What is this PR for? Currently, if users set their own `SPARK_HOME`, they can not get `zeppelin-interpreter-spark-xxxx.log` file. This PR is for fixing this issue. (This issue is reported by weipuz) ### What type of PR is it? Hot Fix ### Todos ### What is the Jira issue? None ### How should this be tested? After applying this PR, 1. Set your own `SPARK_HOME`. 2. Run `sc.version`(or whatever you want) with Spark interpreter. 3. Check under your `ZEPPELIN_HOME/logs/` directory, then you can find `zeppelin-interpreter-spark-xxx.log` file. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: AhyoungRyu <[email protected]> Closes apache#769 from AhyoungRyu/fix-spark-log and squashes the following commits: dcdad56 [AhyoungRyu] Ping travis 8564f8c [AhyoungRyu] Fix interpreter.sh to get Spark interpreter log
weipuz
referenced
this pull request
May 11, 2016
This is the initial PR for an R Interpreter for Zeppelin. There's still some work to be done (e.g., tests), but its useable, it brings to Zeppelin features from R like its library of statistics and machine learning packages, as well as advanced interactive visualizations. So I'd like to open it up for others to comment and/or become involved. Summary: - There are two interpreters, one emulates a REPL, the other uses knitr to weave markdown and formatted R output. The two interpreters share a single execution environment. - Visualisations: Besides R's own graphics, this also supports interactive visualizations with googleVis and rCharts. I am working on htmlwidgets (almost done) with the author of that package, and a next-step project is to get Shiny/ggvis working. Sometimes, a visualization won't load until the page is reloaded. I'm not sure why this is. - Licensing: To talk to R, this integrates code forked from rScala. rScala was released with a BSD-license option, and the author's permission was obtained. - Spark: Getting R to share a single spark context with the Spark interpreter group is going to be a project. For right now, the R interpreters live in their own "r" interpreter group, and new spark contexts are created on startup. - Zeppelin Context: Not yet integrated, in significant part because there's no ZeppelinContext to talk to until it lives in the Spark interpreter group. - Documentation: A notebook is included that demonstrates what the interpreter does and how to use it. - Tests: Working on it... P.S.: This is my first PR on a project of this size; let me know what I messed up and I'll try to fix it ASAP. Author: Amos Elb <[email protected]> Author: Amos B. Elberg <[email protected]> Closes #208 from elbamos/rinterpreter and squashes the following commits: ffc1a25 [Amos Elb] Fix rat issue a08ec5b [Amos B. Elberg] R Interpreter
2 tasks
asfgit
pushed a commit
that referenced
this pull request
May 19, 2016
### What is this PR for? This PR apply fix #769 again, which is reverted by #208. Also removing unnecessary code from interpreter.sh ### What type of PR is it? Bug Fix ### Todos * [x] - Apply #769 again * [x] - Remove unnecessary code ### What is the Jira issue? ### How should this be tested? ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Lee moon soo <[email protected]> Closes #889 from Leemoonsoo/fix_interpreter_sh_classpath and squashes the following commits: 8468fd5 [Lee moon soo] Remove unnecessary construction of classpath ea8fee8 [Lee moon soo] Apply pr769 again, reverted by pr208
shijinkui
pushed a commit
to shijinkui/incubator-zeppelin
that referenced
this pull request
May 26, 2016
### What is this PR for? This PR apply fix apache#769 again, which is reverted by apache#208. Also removing unnecessary code from interpreter.sh ### What type of PR is it? Bug Fix ### Todos * [x] - Apply apache#769 again * [x] - Remove unnecessary code ### What is the Jira issue? ### How should this be tested? ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Lee moon soo <[email protected]> Closes apache#889 from Leemoonsoo/fix_interpreter_sh_classpath and squashes the following commits: 8468fd5 [Lee moon soo] Remove unnecessary construction of classpath ea8fee8 [Lee moon soo] Apply pr769 again, reverted by pr208
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Currently, if users set their own
SPARK_HOME, they can not getzeppelin-interpreter-spark-xxxx.logfile. This PR is for fixing this issue.(This issue is reported by @weipuz)
What type of PR is it?
Hot Fix
Todos
What is the Jira issue?
None
How should this be tested?
After applying this PR,
SPARK_HOME.sc.version(or whatever you want) with Spark interpreter.ZEPPELIN_HOME/logs/directory, then you can findzeppelin-interpreter-spark-xxx.logfile.Screenshots (if appropriate)
Questions: