Skip to content

[ZEPPELIN-6288] Replace Yoda conditions in InterpreterFactory with standard null checks #5037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2025
Merged

[ZEPPELIN-6288] Replace Yoda conditions in InterpreterFactory with standard null checks #5037

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public Interpreter getInterpreter(String replName,
String group = replNameSplits[0];
String name = replNameSplits[1];
InterpreterSetting setting = interpreterSettingManager.getByName(group);
if (null != setting) {
if (setting != null) {
Interpreter interpreter = setting.getInterpreter(executionContext, name);
if (null != interpreter) {
return interpreter;
Expand All @@ -74,7 +74,7 @@ public Interpreter getInterpreter(String replName,

// then assume interpreter name is omitted
setting = interpreterSettingManager.getByName(replName);
if (null != setting) {
if (setting != null) {
return setting.getDefaultInterpreter(executionContext);
}
}
Expand Down
Loading