[ZEPPELIN-6288] Replace Yoda conditions in InterpreterFactory with standard null checks #5037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Aug 22, 2025
…andard null checks ### What is this PR for? In `src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java` The codebase contains several instances of Yoda conditions (e.g., `if (null != setting)`) which negatively impact code readability. Additionally, the use of these checks causes inconsistencies with the existing codebase style. So, this improvement aligns the code with the standard null-check style. ### What type of PR is it? Refactoring ### Todos * [x] - Refactor null-check style ### What is the Jira issue? * [ZEPPELIN-6288](https://issues.apache.org/jira/browse/ZEPPELIN-6288) ### How should this be tested? * As this modification involves no functional changes but only coding style improvements, passing existing tests ensures there are no issues. ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? - No * Is there breaking changes for older versions? - No * Does this needs documentation? - No Closes #5037 from hyunw9/origin/ZEPPELIN-6288. Signed-off-by: Philipp Dallig <[email protected]> (cherry picked from commit f32b50f) Signed-off-by: Philipp Dallig <[email protected]>
Contributor
|
Merged into master and branch-0.12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
In
src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.javaThe codebase contains several instances of Yoda conditions (e.g.,
if (null != setting)) which negatively impact code readability.Additionally, the use of these checks causes inconsistencies with the existing codebase style. So, this improvement aligns the code with the standard null-check style.
What type of PR is it?
Refactoring
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: