Skip to content

[ZEPPELIN-4790]. Throw exception when using flink for scala 2.12 #3763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zjffdu wants to merge 2 commits into from
Closed

[ZEPPELIN-4790]. Throw exception when using flink for scala 2.12 #3763

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57b0737
[ZEPPELIN-4790]. Throw exception when using flink for scala 2.12
zjffdu May 6, 2020
eac7b9a
address comment
zjffdu May 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions flink/src/main/java/org/apache/zeppelin/flink/FlinkInterpreter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,18 +48,39 @@ public class FlinkInterpreter extends Interpreter {

public FlinkInterpreter(Properties properties) {
super(properties);
this.innerIntp = new FlinkScalaInterpreter(getProperties());
}

private String extractScalaVersion() throws InterpreterException {
String scalaVersionString = scala.util.Properties.versionString();
LOGGER.info("Using Scala: " + scalaVersionString);
if (scalaVersionString.contains("version 2.10")) {
return "2.10";
} else if (scalaVersionString.contains("version 2.11")) {
return "2.11";
} else if (scalaVersionString.contains("version 2.12")) {
return "2.12";
} else {
throw new InterpreterException("Unsupported scala version: " + scalaVersionString);
}

@alexott alexott May 6, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we plan to support multiple Scala versions in the future, and have some functionality depending on it?
Otherwise I would maybe just implement something like "isSupportedScalaVersion" with one check for Scala 2.11 as of now.

@zjffdu zjffdu May 6, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed

}

@Override
public void open() throws InterpreterException {
String scalaVersion = extractScalaVersion();
if (!scalaVersion.equals("2.11")) {
throw new InterpreterException("Only scala 2.11 is supported for flink, " +
"but the current scala version is: " + scalaVersion);
}
this.innerIntp = new FlinkScalaInterpreter(getProperties());
this.innerIntp.open();
this.z = this.innerIntp.getZeppelinContext();
}

@Override
public void close() throws InterpreterException {
this.innerIntp.close();
if (this.innerIntp != null) {
this.innerIntp.close();
}
}

@Override
Expand Down