[ZEPPELIN-4790]. Throw exception when using flink for scala 2.12 #3763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexott
approved these changes
May 6, 2020
Contributor
alexott
left a comment
alexott
left a comment
There was a problem hiding this comment.
looks ok, although I'm not sure if we need to make it so complex.
Comment on lines
53
to
64
| private String extractScalaVersion() throws InterpreterException { | ||
| String scalaVersionString = scala.util.Properties.versionString(); | ||
| LOGGER.info("Using Scala: " + scalaVersionString); | ||
| if (scalaVersionString.contains("version 2.10")) { | ||
| return "2.10"; | ||
| } else if (scalaVersionString.contains("version 2.11")) { | ||
| return "2.11"; | ||
| } else if (scalaVersionString.contains("version 2.12")) { | ||
| return "2.12"; | ||
| } else { | ||
| throw new InterpreterException("Unsupported scala version: " + scalaVersionString); | ||
| } |
Contributor
There was a problem hiding this comment.
Do we plan to support multiple Scala versions in the future, and have some functionality depending on it?
Otherwise I would maybe just implement something like "isSupportedScalaVersion" with one check for Scala 2.11 as of now.
asfgit
pushed a commit
that referenced
this pull request
May 8, 2020
### What is this PR for? This PR will throw exception when using flink for scala 2.12 which is not supported now. See the screenshot below. ### What type of PR is it? [ Improvement ] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-4790 ### How should this be tested? * Manually tested. ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <[email protected]> Closes #3763 from zjffdu/ZEPPELIN-4790 and squashes the following commits: eac7b9a [Jeff Zhang] address comment 57b0737 [Jeff Zhang] [ZEPPELIN-4790]. Throw exception when using flink for scala 2.12 (cherry picked from commit e229682) Signed-off-by: Jeff Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR will throw exception when using flink for scala 2.12 which is not supported now. See the screenshot below.
What type of PR is it?
[ Improvement ]
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: