Minor refactoring #3760
Closed
Minor refactoring #3760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l then NullPointerExceptions can be avoided, they will just return false.
alexott
approved these changes
May 4, 2020
Contributor
|
LGTM |
1 similar comment
Member
|
LGTM |
asfgit
pushed a commit
that referenced
this pull request
May 6, 2020
### What is this PR for? Position literals first in comparisons, if the second argument is null then NullPointerExceptions can be avoided, they will just return false. Then I will move to annotations and other issues that my static analyzer shows (My previous branch was removed because of the multiple problems, so I decided to start over) ### What type of PR is it? Refactoring ### What is the Jira issue? This task is not on jira, but I'll move to this https://issues.apache.org/jira/browse/ZEPPELIN-3225?filter=12348928 ### How should this be tested? https://travis-ci.org/github/KirillTurchinskii/zeppelin/builds/682716706 ### Screenshots (if appropriate) ### Questions: * What else besides annotations (that I will add) I can fix/refactor using static analysis? Author: Kirill Turchinskii <[email protected]> Closes #3760 from KirillTurchinskii/fix2 and squashes the following commits: 6b4ce16 [Kirill Turchinskii] Position literals first in comparisons, if the second argument is null then NullPointerExceptions can be avoided, they will just return false. (cherry picked from commit 302c287) Signed-off-by: Alex Ott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Position literals first in comparisons, if the second argument is null then NullPointerExceptions can be avoided, they will just return false.
Then I will move to annotations and other issues that my static analyzer shows
(My previous branch was removed because of the multiple problems, so I decided to start over)
What type of PR is it?
Refactoring
What is the Jira issue?
This task is not on jira, but I'll move to this
https://issues.apache.org/jira/browse/ZEPPELIN-3225?filter=12348928
How should this be tested?
https://travis-ci.org/github/KirillTurchinskii/zeppelin/builds/682716706
Screenshots (if appropriate)
Questions: