[ZEPPELIN-3225] Minor fix for missing annotations #3759
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can you please add Travis CI link? |
Contributor
Author
|
Even master branch build is failed.
https://travis-ci.org/github/KirillTurchinskii/zeppelin/builds
вс, 3 мая 2020 г. в 11:38, Alex Ott <[email protected]>:
… Can you please add Travis CI link?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3759 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFOQDL6HX4CG5MCGLCXXUF3RPUUQPANCNFSM4MX22WKQ>
.
|
Contributor
|
Can you restart only failed jobs? (click icon on the right of the job) |
Reamer
reviewed
May 4, 2020
| * @return | ||
| */ | ||
| protected String createLoginPayload(String login, char[] pwd) { | ||
| protected String createLoginPayload(String login, char ... pwd) { |
Contributor
There was a problem hiding this comment.
What is the reason for this change?
Reamer
reviewed
May 4, 2020
| import static org.junit.Assert.assertEquals; | ||
| import static org.junit.Assert.assertNotNull; | ||
| import static org.junit.Assert.assertThat; | ||
| import static org.junit.Assert.*; |
Contributor
There was a problem hiding this comment.
I would prefer a list of imports and no wildcard.
Contributor
There was a problem hiding this comment.
checkstyle plugin should catchup this, at least in main code....
Contributor
Author
|
New pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Some code refactoring is done, annotations added, and some of warnings has been removed
What type of PR is it?
Refactoring
Todos
Refactoring and Annotations added
###What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-3225?filter=12348928
How should this be tested?
Screenshots (if appropriate)
Questions: