Skip to content

Conversation

@Reamer
Copy link
Contributor

@Reamer Reamer commented Apr 20, 2020

What is this PR for?

This PR fixes a small part of #3571, which introduced a SSL-connector regression.

The port definition of the SSL connector has been deleted.
https://github.com/apache/zeppelin/pull/3571/files#diff-3477d79f3012453f20c3727ec60338e9L337-L341

What type of PR is it?

  • Hot Fix

Todos

  • - Task

What is the Jira issue?

How should this be tested?

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@zjffdu
Copy link
Contributor

zjffdu commented Apr 21, 2020

LGTM

@Reamer
Copy link
Contributor Author

Reamer commented Apr 23, 2020

If something blocks the merge, let me know.

@asfgit asfgit closed this in f577f1e Apr 23, 2020
asfgit pushed a commit that referenced this pull request Apr 23, 2020
### What is this PR for?
This PR fixes a small part of #3571, which introduced a SSL-connector regression.

The port definition of the SSL connector has been deleted.
https://github.com/apache/zeppelin/pull/3571/files#diff-3477d79f3012453f20c3727ec60338e9L337-L341

### What type of PR is it?
 - Hot Fix

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-4766

### How should this be tested?
* **Travis-CI:** https://travis-ci.org/github/Reamer/zeppelin/builds/677349664

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Philipp Dallig <[email protected]>

Closes #3740 from Reamer/ssl_regression and squashes the following commits:

44125ce [Philipp Dallig] Fix SSL regression

(cherry picked from commit f577f1e)
Signed-off-by: Alex Ott <[email protected]>
@Reamer Reamer deleted the ssl_regression branch April 23, 2020 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants