[ZEPPELIN-4515] Have Jetty Server support multiple wars #3571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the contribution @fred521 |
Author
add the Jira link to the PR. Would love to share anything, presto note tutorial means presto notebook that created by our users ? |
Contributor
|
@fred521 Could you update the PR title and description, please follow the contribution guildeline here. http://zeppelin.apache.org/community.html Regarding the presto, I mean you added presto note in this PR. 😄 |
Author
haha, that was a mistake, thanks 😄😄😄 |
fred521
changed the title
Contributor
|
@fred521 I tried this PR, but could not open the new angular ui. Anything else need to configure ?
|
Contributor
|
@fred521 I can make it work by changing this line to following https://github.com/apache/zeppelin/pull/3571/files#diff-179ea3a816210bb9904baabec1a552e4R825 Thanks @hsuanxyz for the hint. |
Contributor
|
Thanks @fred521 LGTM , will merge if no more comment |
asfgit
pushed a commit
that referenced
this pull request
Jan 3, 2020
### What is this PR for? We have a new UI with version angular 8, which will be retiring the old angularjs. both of the angular frameworks may need to co-exist for a while until the new UI is stable. Have the Jetty server support multiple wars with different port (8080 and 9090) ### What type of PR is it? [Feature ] ### Todos retire angularJS completely in the future. ### What is the Jira issue? * [ZEPPELIN-4515](https://issues.apache.org/jira/browse/ZEPPELIN-4515) Have Jetty Server support multiple wars Add multiple war support for the Zeppelin Server. two ports (default is 8080 and 9090) will be living for a while until we are comfortable with the new UI. ### How should this be tested? The default port for new UI is 9090, testing via http://localhost:9090 ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? **No** * Is there breaking changes for older versions? **No** * Does this needs documentation? **No** Author: fdai <[email protected]> Closes #3571 from fred521/add_angular_to_jetty and squashes the following commits: 1965476 [fdai] add next context path 93e2a4f [fdai] clean the code 8606ce0 [fdai] use one port two support multiple wars in jetty f08602e [fdai] remove unrelated notebook 0f9c103 [fdai] add angular support for jetty
Contributor
|
@fred521 I have merged it, could you close this PR ? |
asfgit
pushed a commit
that referenced
this pull request
Jan 12, 2020
### What is this PR for? We have a new UI with version angular 8, which will be retiring the old angularjs. both of the angular frameworks may need to co-exist for a while until the new UI is stable. Have the Jetty server support multiple wars with different port (8080 and 9090) ### What type of PR is it? [Feature ] ### Todos retire angularJS completely in the future. ### What is the Jira issue? * [ZEPPELIN-4515](https://issues.apache.org/jira/browse/ZEPPELIN-4515) Have Jetty Server support multiple wars Add multiple war support for the Zeppelin Server. two ports (default is 8080 and 9090) will be living for a while until we are comfortable with the new UI. ### How should this be tested? The default port for new UI is 9090, testing via http://localhost:9090 ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? **No** * Is there breaking changes for older versions? **No** * Does this needs documentation? **No** Author: fdai <[email protected]> Closes #3571 from fred521/add_angular_to_jetty and squashes the following commits: 1965476 [fdai] add next context path 93e2a4f [fdai] clean the code 8606ce0 [fdai] use one port two support multiple wars in jetty f08602e [fdai] remove unrelated notebook 0f9c103 [fdai] add angular support for jetty
1 task
asfgit
pushed a commit
that referenced
this pull request
Apr 23, 2020
### What is this PR for? This PR fixes a small part of #3571, which introduced a SSL-connector regression. The port definition of the SSL connector has been deleted. https://github.com/apache/zeppelin/pull/3571/files#diff-3477d79f3012453f20c3727ec60338e9L337-L341 ### What type of PR is it? - Hot Fix ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-4766 ### How should this be tested? * **Travis-CI:** https://travis-ci.org/github/Reamer/zeppelin/builds/677349664 ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Philipp Dallig <[email protected]> Closes #3740 from Reamer/ssl_regression and squashes the following commits: 44125ce [Philipp Dallig] Fix SSL regression
asfgit
pushed a commit
that referenced
this pull request
Apr 23, 2020
### What is this PR for? This PR fixes a small part of #3571, which introduced a SSL-connector regression. The port definition of the SSL connector has been deleted. https://github.com/apache/zeppelin/pull/3571/files#diff-3477d79f3012453f20c3727ec60338e9L337-L341 ### What type of PR is it? - Hot Fix ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-4766 ### How should this be tested? * **Travis-CI:** https://travis-ci.org/github/Reamer/zeppelin/builds/677349664 ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Philipp Dallig <[email protected]> Closes #3740 from Reamer/ssl_regression and squashes the following commits: 44125ce [Philipp Dallig] Fix SSL regression (cherry picked from commit f577f1e) Signed-off-by: Alex Ott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
We have a new UI with version angular 8, which will be retiring the old angularjs.
both of the angular frameworks may need to co-exist for a while until the new UI is stable.
Have the Jetty server support multiple wars with different port (8080 and 9090)
What type of PR is it?
[Feature ]
Todos
retire angularJS completely in the future.
What is the Jira issue?
Add multiple war support for the Zeppelin Server.
two ports (default is 8080 and 9090) will be living for a while until we are comfortable with the new UI.
How should this be tested?
The default port for new UI is 9090, testing via http://localhost:9090
Screenshots (if appropriate)
Questions: