Skip to content

[ZEPPELIN-4697] Zeppelin Quartz scheduler checks for updates against external endpoint #3700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
risdenk wants to merge 1 commit into from
Closed

[ZEPPELIN-4697] Zeppelin Quartz scheduler checks for updates against external endpoint #3700

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ...-zengine/src/main/java/org/apache/zeppelin/notebook/scheduler/QuartzSchedulerService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public QuartzSchedulerService(ZeppelinConfiguration zeppelinConfiguration, Noteb
throws SchedulerException {
this.zeppelinConfiguration = zeppelinConfiguration;
this.notebook = notebook;
this.scheduler = new StdSchedulerFactory().getScheduler();
this.scheduler = getScheduler();
this.scheduler.start();

// Do in a separated thread because there may be many notes,
Expand Down Expand Up @@ -85,6 +85,13 @@ public QuartzSchedulerService(ZeppelinConfiguration zeppelinConfiguration, Noteb
loadingNotesThread.start();
}

private Scheduler getScheduler() throws SchedulerException {
// Make sure to not check for Quartz update since this leaks information about running process
// http://www.quartz-scheduler.org/documentation/2.4.0-SNAPSHOT/best-practices.html#skip-update-check
System.setProperty(StdSchedulerFactory.PROP_SCHED_SKIP_UPDATE_CHECK, "true");
return new StdSchedulerFactory().getScheduler();
}

/**
* This is only for testing, unit test should always call this method in setup() before testing.
*/
Expand Down