Skip to content

[ZEPPELIN-4697] Zeppelin Quartz scheduler checks for updates against external endpoint #3700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
risdenk wants to merge 1 commit into from
Closed

[ZEPPELIN-4697] Zeppelin Quartz scheduler checks for updates against external endpoint #3700

risdenk wants to merge 1 commit into from

Conversation

@risdenk
Copy link
Contributor

@risdenk risdenk commented Mar 27, 2020

What is this PR for?

Zeppelin uses the Quartz scheduler which has a
built in update checker. This reaches out to a
Terracotta update server which leaks some
information about the running server. This is
recommended to be disabled in the docs.

http://www.quartz-scheduler.org/documentation/2.4.0-SNAPSHOT/best-practices.html#skip-update-check

What type of PR is it?

Bug Fix

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-4697

How should this be tested?

  • CI tests
  • Manually confirmed this removes the update check call to the Terracotta server

Questions:

  • Does the licenses files need update? - No
  • Is there breaking changes for older versions? - No
  • Does this needs documentation? - No

prabhjyotsingh
prabhjyotsingh approved these changes Mar 28, 2020
View reviewed changes
Copy link
Contributor

@prabhjyotsingh prabhjyotsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@risdenk
Copy link
Contributor Author

risdenk commented Mar 28, 2020

Pushed after reenabling travis.org on my fork. Apparently travis.com is not enough for enabling :D

@zjffdu
Copy link
Contributor

zjffdu commented Mar 29, 2020

LGTM, @risdenk What do you mean travis.com is not enough for enabling ? Do you have any trouble to enable travis build ?

@risdenk
Copy link
Contributor Author

risdenk commented Mar 29, 2020

https://travis-ci.com/github/risdenk/zeppelin/branches

vs

https://travis-ci.org/github/risdenk/zeppelin/branches

I didn't have it enabled on travis-ci.org and only had it enabled on travis-ci.com. About a year or two ago there was a push to move repos from .org to .com. I think that stopped, but I had started doing that. I just had to enable it for travis-ci.org. It looks like it is enabled now. There are a few failures, but doubt they are related to this change.

@risdenk
Copy link
Contributor Author

risdenk commented Mar 29, 2020

This is the build that was triggered:

https://travis-ci.org/github/risdenk/zeppelin/builds/668096158

@zjffdu
Copy link
Contributor

zjffdu commented Mar 29, 2020

@risdenk This failure is related https://travis-ci.org/github/risdenk/zeppelin/jobs/668096163
Others are not related

@risdenk
[ZEPPELIN-4697] Zeppelin Quartz scheduler checks for updates against …
511d868 
…external endpoint

Zeppelin uses the Quartz scheduler which has a
built in update checker. This reaches out to a
Terracotta update server which leaks some
information about the running server. This is
recommended to be disabled in the docs.

http://www.quartz-scheduler.org/documentation/2.4.0-SNAPSHOT/best-practices.html#skip-update-check

Signed-off-by: Kevin Risden <[email protected]>
@risdenk
Copy link
Contributor Author

risdenk commented Mar 30, 2020

Thanks @zjffdu I updated the PR to address the test failure. It is now avoiding creating a separate config properties for the Quartz scheduler.

@risdenk
Copy link
Contributor Author

risdenk commented Mar 30, 2020

New travis run in progress: https://travis-ci.org/github/risdenk/zeppelin/builds/668794051

@risdenk
Copy link
Contributor Author

risdenk commented Mar 30, 2020

Failures from NotebookTest are gone. Looks like the two job failures aren't related.

@zjffdu
Copy link
Contributor

zjffdu commented Mar 31, 2020

Thanks @risdenk These 2 failure are note related, thanks for your contribution, will merge it soon

@asfgit asfgit closed this in a7c75de Apr 1, 2020
asfgit pushed a commit that referenced this pull request Apr 1, 2020
@risdenk @zjffdu
[ZEPPELIN-4697] Zeppelin Quartz scheduler checks for updates against …
2c78df3 
…external endpoint

### What is this PR for?

Zeppelin uses the Quartz scheduler which has a
built in update checker. This reaches out to a
Terracotta update server which leaks some
information about the running server. This is
recommended to be disabled in the docs.

http://www.quartz-scheduler.org/documentation/2.4.0-SNAPSHOT/best-practices.html#skip-update-check

### What type of PR is it?
Bug Fix

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-4697

### How should this be tested?
* CI tests
* Manually confirmed this removes the update check call to the Terracotta server

### Questions:
* Does the licenses files need update? - No
* Is there breaking changes for older versions? - No
* Does this needs documentation? - No

Author: Kevin Risden <[email protected]>

Closes #3700 from risdenk/ZEPPELIN-4697 and squashes the following commits:

511d868 [Kevin Risden] [ZEPPELIN-4697] Zeppelin Quartz scheduler checks for updates against external endpoint

(cherry picked from commit a7c75de)
Signed-off-by: Jeff Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prabhjyotsingh prabhjyotsingh prabhjyotsingh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@risdenk @zjffdu @prabhjyotsingh